From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966736AbdAKNmJ (ORCPT ); Wed, 11 Jan 2017 08:42:09 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:55047 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937381AbdAKNmH (ORCPT ); Wed, 11 Jan 2017 08:42:07 -0500 From: Arnd Bergmann To: Jaroslav Kysela , Takashi Iwai Cc: Arnd Bergmann , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH] ALSA: hda/ca0132 - fix possible NULL pointer use Date: Wed, 11 Jan 2017 14:39:44 +0100 Message-Id: <20170111134013.3798733-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:LXU5WRePEE7Qz2oHCQNE14hEV357keguf7U4EkGU0ibt5yWGLqh OyZPyZeBg7nzxBDrYW2fByHoBAA2i8kss/OsLNkdJLx3FWSVqR+PzHjr2BZEu6L2MlNWKBA vMVexydjZI2P458IGajWn0fNQTAaPn05GQugcssMwnyRRf0Nycbg1RfNqJAqRlD2K8oDqNg jqqiHbA2tjf8BvdOrqw5g== X-UI-Out-Filterresults: notjunk:1;V01:K0:6L84/dt5RX4=:QTm0P/sFnIW0nfI+4qqJEn hodmTsQ4FDNQU3Dt5sy5WkuQiQMwSbjhQ8JW4vh3Wd23DxwOqqA+Lwj82s+rQXmK6i1FAtXbB oyJ42FjoQOeQID3qXXmlumZCRCX+GMs4ccE4k2nD+PTeyq2a5TNxOvK0SRjyBqyQ41vm04Lzf cXil9LGrGl16gL4MR6gXSYkaqqWh8ci8A16CMwRvMNTBHpEG2P/H78p/VDAXr1WDmNZteeJfq keNKGcmdk6ZWPUku2XPQplM5++3JvlUw9dWenex7w4p86K0CvCbUvMtuiCpJolm6C2qnxLe4u NKXH2F8esB4Pl62vQazPVkQVTHrwdLAAlYjAH8XwJMx4otXjAixA8+O4qBPM3hAb2MHDxNRRP mHwje92TG9iPTZpdBWvZj/og0mg4pDR4uHvls6nXudXPosT7Wt0Mqh5gH0Ky6AyMYXkikSk2d 3YEyapFhwdeCeBNnwMGOhaTVC2pc3wLluYK335hOjCEy5rB1Jb6eSHRsd5ysp5cD8Kw8J/iXT pxMzIv2AtDINyz5iD0uJHaPsrz2ZIu35VL5UWmrFgXpuOx5rI7J0hwyAdtx/gtyjCtTlgjPnx StngTGll09S60K/zVgO2Irgtx35jQQfqk+AnIlFvKROBz2P0A5rkGBHrBkgeEaWGU2ZrJAfeH 63EmwEeVYWwgJEYSOKHFtsN2I4c03eJhUc0Lzm7FvYXUaTQw1SjUQdnwbXs3mCkyBDSY= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gcc-7 caught what it considers a NULL pointer dereference: sound/pci/hda/patch_ca0132.c: In function 'dspio_scp.constprop': sound/pci/hda/patch_ca0132.c:1487:4: error: argument 1 null where non-null expected [-Werror=nonnull] This is plausible from looking at the function, as we compare 'reply' to NULL earlier in it. I have not tried to analyze if there are constraints that make it impossible to hit the bug, but adding another NULL check in the end kills the warning and makes the function more robust. Signed-off-by: Arnd Bergmann --- sound/pci/hda/patch_ca0132.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c index bd7c29f8ab1e..07a9deb17477 100644 --- a/sound/pci/hda/patch_ca0132.c +++ b/sound/pci/hda/patch_ca0132.c @@ -1482,6 +1482,9 @@ static int dspio_scp(struct hda_codec *codec, } else if (ret_size != reply_data_size) { codec_dbg(codec, "RetLen and HdrLen .NE.\n"); return -EINVAL; + } else if (!reply) { + codec_dbg(codec, "NULL reply\n"); + return -EINVAL; } else { *reply_len = ret_size*sizeof(unsigned int); memcpy(reply, scp_reply.data, *reply_len); -- 2.9.0