From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967479AbdAKOl4 (ORCPT ); Wed, 11 Jan 2017 09:41:56 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:55305 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967388AbdAKOlx (ORCPT ); Wed, 11 Jan 2017 09:41:53 -0500 From: Arnd Bergmann To: Andrew Morton Cc: Alex Dubov , Arnd Bergmann , linux-kernel@vger.kernel.org Subject: [PATCH] memstick: core: avoid -Wnonnull warning Date: Wed, 11 Jan 2017 15:40:07 +0100 Message-Id: <20170111144143.548867-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:VZt2ngRvskOgqv7UaPiMv2nIefidS/dTQ+b2MW2d8Y5B7O2C0Z/ n8hkCcF4FCbIbeoTCNa/gkRRF4MmtORl/0FMR41NIw2B0nFauZ/nwQMdAPxIVHV8tx2VdKP tlIOPp/xG7YVvuF9AL0RqZo6Vdrq5ZYa9jIHku99xWktcaU8Ci7hXcI21StjrCPZOyqpu/m /7OL5HGJmcNCLWPVyL13A== X-UI-Out-Filterresults: notjunk:1;V01:K0:JdYCnhG8bDs=:9hYv1zSS1TKJbtgM4Jp49V l4v4g48sGR9QBwqcdsTuc2HFDulR+J8J3A6UZexf3V2FQAXS/0vKKNCDl4RNq9CTVlYbljq3b dGTu4/o8u8rA7hguJWCC/ZtGzKIa1Seb9QXr9CpP5+zNTBrSnzf438QfwU2mqNu52jC98vAPg slarcpIsoWf3RVDI/FOZAqBjiKNVVJz20uzhhG6MdTg/HMhOx6HFnE1TdtoaKP8F+MTFx3HSC hbNuX8N/Z0c1asFkyb1SBUqfF1USunhs0nGnsFXdDzkUeG/JU5why6pSNRxuPg0qP8KtmZSJQ IYE6f31+k9RL99FRYTtUeGr99l/JV8z33U7P9KIw5AhYiXEATCQc1SL7KFhKr7YM83+Kt8r57 izSART2HNP4LxCHXXy1saKF18udVaLTpkMXz6L3x8qQSuHvwpE2oNzqGDDfPKG7Z8Dbu5OAE2 O8Vbku4yEwg9TxdUoEUNyIYTPLmUA7yShnuGF5pSu8ZWNL8JVTb/pC4C6QxAEUmz/h6M4PLkI ozt72aU8wu+H9to4ZY6KS21jmONG8yKgw5kso8Nri4I4VfBY8LReF+G8ZmeIqPETt01Yu7OW2 ZIturwV1yGFRjXJ0LyQhUa90oyjgLhBLvnehQ1zpfgbZisyMOrPhPMhWK6+RoYb0kNAQUS+UN N4XJsNQ129k4gKDiVotXGuYtRcfvUNwoAk1uFMXECZh1EzXqBVZx1aQa4S0YkKmt9VWE= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gcc-7 produces a harmless false-postive warning about a possible NULL pointer access: drivers/memstick/core/memstick.c: In function 'h_memstick_read_dev_id': drivers/memstick/core/memstick.c:309:3: error: argument 2 null where non-null expected [-Werror=nonnull] memcpy(mrq->data, buf, mrq->data_len); This can't happen because the caller sets the command to 'MS_TPC_READ_REG', which causes the data direction to be 'READ' and the NULL pointer not accessed. As a simple workaround for the warning, we can pass a pointer to the data that we actually want to read into. This is not needed here, but also harmless, and lets the compiler know that the access is ok. Signed-off-by: Arnd Bergmann --- drivers/memstick/core/memstick.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/memstick/core/memstick.c b/drivers/memstick/core/memstick.c index a0547dbf9806..76382c858c35 100644 --- a/drivers/memstick/core/memstick.c +++ b/drivers/memstick/core/memstick.c @@ -330,7 +330,7 @@ static int h_memstick_read_dev_id(struct memstick_dev *card, struct ms_id_register id_reg; if (!(*mrq)) { - memstick_init_req(&card->current_mrq, MS_TPC_READ_REG, NULL, + memstick_init_req(&card->current_mrq, MS_TPC_READ_REG, &id_reg, sizeof(struct ms_id_register)); *mrq = &card->current_mrq; return 0; -- 2.9.0