From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763753AbdAKOwM (ORCPT ); Wed, 11 Jan 2017 09:52:12 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:50911 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763727AbdAKOwJ (ORCPT ); Wed, 11 Jan 2017 09:52:09 -0500 From: Arnd Bergmann To: Alexandre Belloni Cc: Arnd Bergmann , Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Alessandro Zummo , linux-arm-kernel@lists.infradead.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: [PATCH] rtc: armada38x: hide maybe-uninitialized warning Date: Wed, 11 Jan 2017 15:50:31 +0100 Message-Id: <20170111145112.722743-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:+ME8Gd8Xw2amg/jSoI7W7YI5WKo7tDf4hXTtkj+A3OLoAWXUuVc wLG8vI1PugseaUAF27oo7DK2dPR05nU+aoYL7v8dYVVwXrN2dnvj1Jf+/S8w+ExqD4OERVF 4ERg73lTtWyodHGIZjC7CiM6kzSEkg04FHo+SrGto7p31jvQGPtWZbINMrD/N2DYCh8oY67 5A79e+rmCakyD2F10WDqw== X-UI-Out-Filterresults: notjunk:1;V01:K0:dt0Al7Cz16k=:pPZl17kJuEprUuMCVnOW1y JRrJsrpXOag5E26Sf+lhWjtVApfRjwOtXLq8gOA+cTG942LEkauwf3fPl1ItGDJ99hODObC5a MLoGLYLP0qO+Sl744ZWiIiWTZ0vmTI/9/Cj1Y3ALMyf4mozvsE9zrqGA71w67QXQmPcJtLahX gJni4BJahAWaVqryjtWzqfQAIMDqgBEmzYso6Ey71iC+QGKAIHriwVw/eOWvfZVj1b6ggAv1x 558NNZQIU5HsPzlEaZBpFmHAeO2ai0ptLLn0N7RYPOaF+e4VSYist3LuQri6AKQv4WgvLv9gw IbSo2CY9lxDh1EvS5Znhz1JYj4pKoBQ5xJartPFv0zJHvNxKBBlcysks8qrEgawGO2ATUfXz1 dzHg8FHXf9qBCHROcZqn5HZi+3D5oWvcK7A+N2KZaCs6wk3k6Q7UXC+qHT8hn26Zs6+Fh1dWR pJQntTT+tyqFR7jOE/b5kx8+buSkPoCJ1iU86x/FsRR4T9mSpw3OMzYJlPbx0UVJr2MfFPp1X EIwPaZ8HG+wgUIxlrJ3f9/fOFVjEREV78+nJR/H1/OdvsQrCleebCUYwhmOaQJIFodTZr7Aco Jayk3KGZBrX16dtykRWeMjkeRUNHiV/Sr0uifw7xK0GHHHuANX6538iNcUD/QtUQFUx3vv26r 5MwAIaqYRmUN5lWzUR8i1f0H1Th1HRa636eU6xR2SSy8TruvVW3yZtVRNiLRGWHYc+Co= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function is too complicated for gcc to realize that this variable does eventually get initialized, causing a harmless warning: drivers/rtc/rtc-armada38x.c: In function 'read_rtc_register_wa': drivers/rtc/rtc-armada38x.c:131:25: warning: 'index_max' may be used uninitialized in this function [-Wmaybe-uninitialized] This adds an explicit initializion at the start of the function. I generally try to avoid that, but it seems appropriate here, as we start out with max=0 as well. Fixes: 61cffa2438e3 ("rtc: armada38x: Follow the new recommendation for errata implementation") Signed-off-by: Arnd Bergmann --- drivers/rtc/rtc-armada38x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-armada38x.c b/drivers/rtc/rtc-armada38x.c index 6c9a2cbdc1a9..65e16965af7e 100644 --- a/drivers/rtc/rtc-armada38x.c +++ b/drivers/rtc/rtc-armada38x.c @@ -90,7 +90,7 @@ static void rtc_update_mbus_timing_params(struct armada38x_rtc *rtc) static u32 read_rtc_register_wa(struct armada38x_rtc *rtc, u8 rtc_reg) { - int i, index_max, max = 0; + int i, index_max = 0, max = 0; for (i = 0; i < SAMPLE_NR; i++) { rtc->val_to_freq[i].value = readl(rtc->regs + rtc_reg); -- 2.9.0