From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938499AbdAKQEI (ORCPT ); Wed, 11 Jan 2017 11:04:08 -0500 Received: from mx2.suse.de ([195.135.220.15]:39077 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752423AbdAKQEG (ORCPT ); Wed, 11 Jan 2017 11:04:06 -0500 Date: Wed, 11 Jan 2017 17:03:48 +0100 From: David Sterba To: Michal Hocko Cc: Chris Mason , David Sterba , Josef Bacik , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Hocko Subject: Re: [PATCH 2/2] btrfs: drop gfp mask tweaking in try_release_extent_state Message-ID: <20170111160348.GK12081@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Michal Hocko , Chris Mason , David Sterba , Josef Bacik , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Hocko References: <20170109143903.32280-1-mhocko@kernel.org> <20170109143903.32280-2-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170109143903.32280-2-mhocko@kernel.org> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 09, 2017 at 03:39:03PM +0100, Michal Hocko wrote: > From: Michal Hocko > > try_release_extent_state reduces the gfp mask to GFP_NOFS if it is > compatible. This is true for GFP_KERNEL as well. There is no real > reason to do that though. There is no new lock taken down the > the only consumer of the gfp mask which is > try_release_extent_state > clear_extent_bit > __clear_extent_bit > alloc_extent_state > > So this seems just unnecessary and confusing. > > Signed-off-by: Michal Hocko Reviewed-by: David Sterba