From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765629AbdAKQZg (ORCPT ); Wed, 11 Jan 2017 11:25:36 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33407 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1765606AbdAKQZd (ORCPT ); Wed, 11 Jan 2017 11:25:33 -0500 Date: Wed, 11 Jan 2017 17:25:23 +0100 From: Daniel Vetter To: Lucas Stach Cc: Arnd Bergmann , Daniel Vetter , Rob Clark , David Airlie , linux-arm-msm@vger.kernel.org, etnaviv@lists.freedesktop.org, Christian Gmeiner , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Russell King , Benjamin Gaignard , freedreno@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm: add more MMU dependencies Message-ID: <20170111162523.3akgmd4vfury6ua5@phenom.ffwll.local> Mail-Followup-To: Lucas Stach , Arnd Bergmann , Rob Clark , David Airlie , linux-arm-msm@vger.kernel.org, etnaviv@lists.freedesktop.org, Christian Gmeiner , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Russell King , Benjamin Gaignard , freedreno@lists.freedesktop.org References: <20170111133357.3664191-1-arnd@arndb.de> <20170111133357.3664191-2-arnd@arndb.de> <1484143359.30810.12.camel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484143359.30810.12.camel@pengutronix.de> X-Operating-System: Linux phenom 4.8.0-1-amd64 User-Agent: NeoMutt/20161126 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 11, 2017 at 03:02:39PM +0100, Lucas Stach wrote: > Am Mittwoch, den 11.01.2017, 14:33 +0100 schrieb Arnd Bergmann: > > Many DRM drivers only work with an MMU, and after the patch to enable > > core DRM support without MMU, we already had one fixup for many of them. > > The etnaviv, armada and msm drivers were missed and have the same problem: > > > > warning: (DRM_ETNAVIV) selects IOMMU_SUPPORT which has unmet direct dependencies (MMU) > > warning: (DRM_I915 && DRM_MSM && DRM_ETNAVIV) selects SHMEM which has unmet direct dependencies (MMU) > > drivers/gpu/drm/armada/armada_gem.o: In function `armada_gem_vm_fault': > > armada_gem.c:(.text.armada_gem_vm_fault+0x14): undefined reference to `vm_insert_pfn' > > arch/arm/mm/dma-mapping.c: In function '__iommu_alloc_remap': > > arch/arm/mm/dma-mapping.c:1390:4: error: 'VM_ARM_DMA_CONSISTENT' undeclared (first use in this function) > > arch/arm/mm/dma-mapping.c:1456:31: error: 'atomic_pool' undeclared (first use in this function); did you mean 'atomic_xor'? > > > > Fixes: 011cda589938 ("drm: fix compilations issues introduced by "drm: allow to use mmuless SoC"") > > Fixes: 62a0d98a188c ("drm: allow to use mmuless SoC") > > Signed-off-by: Arnd Bergmann > > Acked-by: Lucas Stach Applied to drm-misc, thanks. -Daniel > > > --- > > drivers/gpu/drm/armada/Kconfig | 2 +- > > drivers/gpu/drm/etnaviv/Kconfig | 1 + > > drivers/gpu/drm/msm/Kconfig | 1 + > > 3 files changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/armada/Kconfig b/drivers/gpu/drm/armada/Kconfig > > index 15f3ecfb16f1..eafaeeb7b5b1 100644 > > --- a/drivers/gpu/drm/armada/Kconfig > > +++ b/drivers/gpu/drm/armada/Kconfig > > @@ -1,6 +1,6 @@ > > config DRM_ARMADA > > tristate "DRM support for Marvell Armada SoCs" > > - depends on DRM && HAVE_CLK && ARM > > + depends on DRM && HAVE_CLK && ARM && MMU > > select DRM_KMS_HELPER > > help > > Support the "LCD" controllers found on the Marvell Armada 510 > > diff --git a/drivers/gpu/drm/etnaviv/Kconfig b/drivers/gpu/drm/etnaviv/Kconfig > > index 2cde7a5442fb..656c061b439d 100644 > > --- a/drivers/gpu/drm/etnaviv/Kconfig > > +++ b/drivers/gpu/drm/etnaviv/Kconfig > > @@ -3,6 +3,7 @@ config DRM_ETNAVIV > > tristate "ETNAVIV (DRM support for Vivante GPU IP cores)" > > depends on DRM > > depends on ARCH_MXC || ARCH_DOVE > > + depends on MMU > > select SHMEM > > select TMPFS > > select IOMMU_API > > diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig > > index d96b2b6898a3..7f78da695dff 100644 > > --- a/drivers/gpu/drm/msm/Kconfig > > +++ b/drivers/gpu/drm/msm/Kconfig > > @@ -4,6 +4,7 @@ config DRM_MSM > > depends on DRM > > depends on ARCH_QCOM || (ARM && COMPILE_TEST) > > depends on OF && COMMON_CLK > > + depends on MMU > > select REGULATOR > > select DRM_KMS_HELPER > > select DRM_PANEL > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch