From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932103AbdAKTST (ORCPT ); Wed, 11 Jan 2017 14:18:19 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:58919 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751487AbdAKTSR (ORCPT ); Wed, 11 Jan 2017 14:18:17 -0500 Date: Wed, 11 Jan 2017 12:18:09 -0700 From: Jason Gunthorpe To: Stefan Berger Cc: Andreas Fuchs , Ken Goldman , greg@enjellic.com, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, tpmdd-devel@lists.sourceforge.net Subject: Re: [tpmdd-devel] [PATCH RFC 0/4] RFC: in-kernel resource manager Message-ID: <20170111191809.GA28593@obsidianresearch.com> References: <201701041612.v04GCfPK031525@wind.enjellic.com> <20170109231635.6wh25qoy7svcnys6@intel.com> <20170110200558.GA5102@obsidianresearch.com> <20170111180328.GB22783@obsidianresearch.com> <7a61bdf9-da82-c772-7e73-d4a4ffc25559@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7a61bdf9-da82-c772-7e73-d4a4ffc25559@linux.vnet.ibm.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.156 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 11, 2017 at 01:27:30PM -0500, Stefan Berger wrote: > On 01/11/2017 01:03 PM, Jason Gunthorpe wrote: > >On Wed, Jan 11, 2017 at 11:00:43AM +0100, Andreas Fuchs wrote: > > > >>could we please get an ioctl, that switches the "mode" of the fd entirely. > >>I'd like to see the write()/read() support still intact. > >>All my current code uses main-loop based poll on the fd and I don't want > >>to be force to start using threads... > >We currently do not support poll in the kernel for /dev/tpmX. > > > >ie we do not supply a poll method for 'struct file_operations'. > > > >Even worse, the current implementation blocks returning from write() > >until the TPM has completed its work, so it doesn't even make sense to > >combine it with poll. > > Newer applications could issue an ioctl() after the open() to unblock the > write(). The ioctl api I outlined could support poll by having userspace set the rxbuf = NULL. The kernel would then launch the tx async and provide poll support to allow read() to return the result once the tpm has finished. This can be added as a new capability down the road.. Jason