From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751036AbdALVVl (ORCPT ); Thu, 12 Jan 2017 16:21:41 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:57786 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750762AbdALVVj (ORCPT ); Thu, 12 Jan 2017 16:21:39 -0500 Date: Thu, 12 Jan 2017 16:21:35 -0500 (EST) Message-Id: <20170112.162135.441956368122992032.davem@davemloft.net> To: f.fainelli@gmail.com Cc: netdev@vger.kernel.org, jason@lakedaemon.net, andrew@lunn.ch, sebastian.hesselbarth@gmail.com, gregory.clement@free-electrons.com, linux@armlinux.org.uk, vivien.didelot@savoirfairelinux.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Subject: Re: [PATCH net-next v2 05/10] drivers: base: Add device_find_class() From: David Miller In-Reply-To: <20170112034121.27697-6-f.fainelli@gmail.com> References: <20170112034121.27697-1-f.fainelli@gmail.com> <20170112034121.27697-6-f.fainelli@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 12 Jan 2017 12:22:31 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Fainelli Date: Wed, 11 Jan 2017 19:41:16 -0800 > Add a helper function to lookup a device reference given a class name. > This is a preliminary patch to remove adhoc code from net/dsa/dsa.c and > make it more generic. > > Signed-off-by: Florian Fainelli > --- > drivers/base/core.c | 19 +++++++++++++++++++ > include/linux/device.h | 1 + > 2 files changed, 20 insertions(+) > > diff --git a/drivers/base/core.c b/drivers/base/core.c > index 020ea7f05520..3dd6047c10d8 100644 > --- a/drivers/base/core.c > +++ b/drivers/base/core.c > @@ -2065,6 +2065,25 @@ struct device *device_find_child(struct device *parent, void *data, > } > EXPORT_SYMBOL_GPL(device_find_child); > > +static int dev_is_class(struct device *dev, void *class) I know you are just moving code, but this class argumnet is a string and thus should be "char *" or even "const char *".