From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751033AbdALVrh (ORCPT ); Thu, 12 Jan 2017 16:47:37 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:58424 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750835AbdALVrf (ORCPT ); Thu, 12 Jan 2017 16:47:35 -0500 Date: Thu, 12 Jan 2017 16:47:31 -0500 (EST) Message-Id: <20170112.164731.720625943370044951.davem@davemloft.net> To: eric.dumazet@gmail.com Cc: shannon.nelson@oracle.com, rob.gardner@oracle.com, netdev@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc From: David Miller In-Reply-To: <1484256990.13165.6.camel@edumazet-glaptop3.roam.corp.google.com> References: <131ec7b7-5b74-2545-8bf7-92812443a876@oracle.com> <20170112.161852.1469407145449781531.davem@davemloft.net> <1484256990.13165.6.camel@edumazet-glaptop3.roam.corp.google.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 12 Jan 2017 12:48:26 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Dumazet Date: Thu, 12 Jan 2017 13:36:30 -0800 > val should be an union, so that proper alignment is enforced by one > member. Sure, annotating the type so that it is aligned correctly makes sense.