From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751041AbdALV7N (ORCPT ); Thu, 12 Jan 2017 16:59:13 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:58716 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750951AbdALV7L (ORCPT ); Thu, 12 Jan 2017 16:59:11 -0500 Date: Thu, 12 Jan 2017 16:58:50 -0500 (EST) Message-Id: <20170112.165850.1803282665815813853.davem@davemloft.net> To: shannon.nelson@oracle.com Cc: eric.dumazet@gmail.com, rob.gardner@oracle.com, netdev@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc From: David Miller In-Reply-To: References: <1484256990.13165.6.camel@edumazet-glaptop3.roam.corp.google.com> <20170112.164731.720625943370044951.davem@davemloft.net> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 12 Jan 2017 12:59:44 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Shannon Nelson Date: Thu, 12 Jan 2017 13:58:10 -0800 > > > On 1/12/2017 1:47 PM, David Miller wrote: >> From: Eric Dumazet >> Date: Thu, 12 Jan 2017 13:36:30 -0800 >> >>> val should be an union, so that proper alignment is enforced by one >>> member. >> >> Sure, annotating the type so that it is aligned correctly makes >> sense. >> > > ... and we should change the offending pointer assignment as well. I > can use this and respin a v2 if we're happy with this solution. I am.