From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751050AbdALHgF (ORCPT ); Thu, 12 Jan 2017 02:36:05 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:37990 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750876AbdALHgD (ORCPT ); Thu, 12 Jan 2017 02:36:03 -0500 Date: Thu, 12 Jan 2017 08:36:15 +0100 From: Greg KH To: Bogdan Purcareata Cc: labbott@redhat.com, sumit.semwal@linaro.org, arve@android.com, riandrews@android.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: android/ion: Fix coding style issues Message-ID: <20170112073615.GB23347@kroah.com> References: <1484169639-18408-1-git-send-email-bogdan.purcareata@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484169639-18408-1-git-send-email-bogdan.purcareata@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 11, 2017 at 11:20:39PM +0200, Bogdan Purcareata wrote: > Fix following checkpatch warnings: > - Lines over 80 characters > - void function with return statement > - Unaligned comment mark > - Header function prototypes missing variable names That's a lot of different things to be doing all in one patch. Please break this up into "one-logical-thing-per-patch" and send this as a patch series. And no, "fix coding style issues" is not "one logical thing". thanks, greg k-h