From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751552AbdALLOR (ORCPT ); Thu, 12 Jan 2017 06:14:17 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:58419 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751516AbdALLOP (ORCPT ); Thu, 12 Jan 2017 06:14:15 -0500 From: Arnd Bergmann To: Alexandre Belloni Cc: Bhumika Goyal , Arnd Bergmann , Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Alessandro Zummo , Russell King , linux-arm-kernel@lists.infradead.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: [PATCH] rtc: armada38x: avoid unused-function warning Date: Thu, 12 Jan 2017 12:13:08 +0100 Message-Id: <20170112111321.3219446-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:6uiDb1q9oLiKVdA0fdWCH8HNbsaPPnAgaLVH+jSiIpSR6hxCTqi NTJHplIg5DDS7sBJ6ehBO2Cww8qHYwWnn1S9Qt0Wdx0m3fvYIHi04yxdJaGAdF9HlxozH8c 6WnfILPtUCT0lQbTlTPm03K/wJLymzJmQXhVG/4AbotNgqph0fcgdNpsg6bwOOcPwuQYQCc uQjfsNtrfXGt5cd1HEUqw== X-UI-Out-Filterresults: notjunk:1;V01:K0:NmFy631/Zqk=:9L4oKoDWUYc8AqYTxR105T PLajcn5JRgcJj7F+cxTtaqNiAqND2THDUcPTCCURNvBwqNgFP5oked0/FcYHoL8R+g6Vostq+ o3QPUPvhCjePVAymXWU/DgMJDHUQ2ANgwbwSVTIAG55AVYN78Uyj2NSVrcJ2dI31ZoxeY0Pkd NL1XhEDvwvRg5qJN7hzqYyRdK6dyUUc835TIXgM/QFA/SJ7ayjD1MsnY08bOXv5aWMv+Mf4S4 5KywfjLuhOac6kABamEbPZzcNO5H3T1ZInp3lVM/k+aTR2+CF3j3NpToGlJEPUl5E2DdnAGXA 1fFTn1qxJuzpzdFXn1s7HCOi3VJKddqeeH5yyyFzSfFbMjj/rqX4IleH76+oIUSvOd/kAclNn xAvyh144XxXLBtECw7h/LMw122jJgcON6bqGYEMLFzh1uMyJKdrSqRYRZ93idnDKZbLIMsFVp KxanfLCbnZLVx7iBDKcLWre501pjsZKVHKryfv41mYKfAsZCjrBrk87SJ5rcNrXPzjk1IeeBg ZX+hEqAmo1r/LZOFIL7patxd1j7M/HuiK48Xruuuwg6U+4PnVFIMa7Dy6g8FJEILDolM7iAG7 6Gw+g8w34r2/k9+nqivedNYmmirPkZU7BuTYq8A5fW6l3vAGJkvZi0kDvQmy0MNJw97lzALfD DfGzAfWqc1xiM4FA7ZAZ5oGY4pqZ7oMk03u6IDomp4djbNyOj1lRCt8+HKDG4Saxodoc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When CONFIG_PM_SLEEP is not set, rtc_update_mbus_timing_params becomes unused, now that armada38x_rtc_probe() no longer calls rtc_update_mbus_timing_params on startup: drivers/rtc/rtc-armada38x.c:79:13: error: 'rtc_update_mbus_timing_params' defined but not used [-Werror=unused-function] This addresses the warning by marking the PM functions as __maybe_unused, so the unused functions get silently dropped. I could not tell from the changelog if dropping the call to armada38x_rtc_probe() was intended here, and if that is the correct thing to do without CONFIG_PM_SLEEP, so we might need a different fix that brings it back. Fixes: 4c492eb022c2 ("rtc: armada38x: make struct rtc_class_ops const") Signed-off-by: Arnd Bergmann --- drivers/rtc/rtc-armada38x.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-armada38x.c b/drivers/rtc/rtc-armada38x.c index 4f75c619bbba..2e451acccd9c 100644 --- a/drivers/rtc/rtc-armada38x.c +++ b/drivers/rtc/rtc-armada38x.c @@ -338,8 +338,7 @@ static __init int armada38x_rtc_probe(struct platform_device *pdev) return 0; } -#ifdef CONFIG_PM_SLEEP -static int armada38x_rtc_suspend(struct device *dev) +static int __maybe_unused armada38x_rtc_suspend(struct device *dev) { if (device_may_wakeup(dev)) { struct armada38x_rtc *rtc = dev_get_drvdata(dev); @@ -350,7 +349,7 @@ static int armada38x_rtc_suspend(struct device *dev) return 0; } -static int armada38x_rtc_resume(struct device *dev) +static int __maybe_unused armada38x_rtc_resume(struct device *dev) { if (device_may_wakeup(dev)) { struct armada38x_rtc *rtc = dev_get_drvdata(dev); @@ -363,7 +362,6 @@ static int armada38x_rtc_resume(struct device *dev) return 0; } -#endif static SIMPLE_DEV_PM_OPS(armada38x_rtc_pm_ops, armada38x_rtc_suspend, armada38x_rtc_resume); -- 2.9.0