From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751195AbdALSmH (ORCPT ); Thu, 12 Jan 2017 13:42:07 -0500 Received: from mail-cys01nam02on0049.outbound.protection.outlook.com ([104.47.37.49]:27280 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750730AbdALSmD (ORCPT ); Thu, 12 Jan 2017 13:42:03 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Robert.Richter@cavium.com; Date: Thu, 12 Jan 2017 19:41:38 +0100 From: Robert Richter To: Will Deacon CC: Catalin Marinas , , Subject: Re: [PATCH] arm64: errata: Provide macro for major and minor cpu revisions Message-ID: <20170112184138.GN4930@rric.localdomain> References: <20170111121143.9586-1-rrichter@cavium.com> <20170112153315.GC13843@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170112153315.GC13843@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [92.224.62.158] X-ClientProxiedBy: HE1P192CA0006.EURP192.PROD.OUTLOOK.COM (10.171.121.144) To BL2PR07MB2338.namprd07.prod.outlook.com (10.167.101.16) X-MS-Office365-Filtering-Correlation-Id: be9b5469-fafd-4aa9-3437-08d43b1aaeb0 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BL2PR07MB2338; X-Microsoft-Exchange-Diagnostics: 1;BL2PR07MB2338;3:dXLtA2XLT7pNOYTQDGROH29ByVRTJRepaOZWTtXIIevcV1TWswNpck7xBuMjF4fgDIZj+sW8Xcirsu0q0UI5pVJfep89hiQ8kz+bj+B3JJF8pYZbj4OLbwo0IFojF9zckCycRlkoZIc60E/iP1eO2ZdYVLPAiiTkrRao5qGHqie1Loggv4A32Q3WiVt8Ahh6BXOs/6vfll5cWFqE/w0/rM/7cYNpuOnulOy8y9TMkyudD3914hr7o+uYKFXv+fqfZi25wmzf/0S6SZKThELiUQ==;25:2jN0SNd2BxXm2cdjDn2GPfqp4rqfzN0LAB/R15XrP23YPuFFqWl7lStXiFP2nms03W7goBdG5Lxl7T+wdfWV2371OD9KUvQxffMIcq+KK8gRWQHPRzSbZoUesM9KvFLYOBDe5Xs0gqpjwgCtfT0RTAISSMyZjTqU/FKXbxwKqaOObyRCDH2f3MhKF8ETM0u0c5BtxnrZt2WuPiDr3YnjXffGfQPNegNIgmyZI0XU3xJ6bhkJPCI8zHm6sDQ2c0D/dzp5ZH19q7f45DRpKq8M0zowlmax8yBRNXYCAeHS8VlHVS1b43lE2XK+KujD8CafQ1opolRffg/woiySYsUXdK1uMqb/eBmkwygNOIiHYb3fCPsVjF5OwHO8CTQl4gwg4WvlETdrAquufvjoFUxXoCL7NBYWMz/BdJKu/6mCEkEB9RU/aV8Kr3R9ZmhavBB6Ir2t+CsyQM29YMBe2CqKOA== X-Microsoft-Exchange-Diagnostics: 1;BL2PR07MB2338;31:fyjKPu5hc91aZIox/xmXEGTKsTFKiP07LAuXogQeoN1P7Nn3D/1r3Z/tP8bt9/eWq8ta9kIrcxAW6vESO/9kxGs3nKatfTPtZfvJAkrEyld4giAoiS/YKBRF4olVywoRo/Snes/NvWp+EV6z/zVPIHxek2EdJLCqcUudBVsied/yB988fKz4mahSOWJoSP8Ps7dzla3eTkntK4OCtZA6KKHBpKhdizdZ3gTEI5IV2/g5cK63jb0Nk/3lgSnC8cWjrY+FL3nqvXNbhF8hB1c6K6wh8acrd0tURFRA5mE/a+A=;20:JTlAykuk5pRyJ8cYc/WXBhc4QNONgtpJpxOxnLGXkVpO2kBAS/+uoYxRDbIGI8+Y8S/FV4q89OUxh3C8vaWVW8fmkadRM/J4/Cifm6nN3pO2YMHn8n2FtX/MjHEHjZvBTnYt4ncK3N/qCSa8xVeFV4cuiAzaX/s8x26a8Q5bIrrRgauCI6Fx2dtxg4Bifee3zKvZ67Jt6CO3x30d7PorT3czE/b7hQMQ7J/gjJ7vJp9VWmt6FTJUxBbD4N/Bw3MmS9IIQG0O2LOwlXQ2fcK2WtAks0I8nWsY4zp/Oa9uSnibRqkIUO3SYw966bzJySNkZIeg+ayGgOUoeXicPRniD2eSb/fJ9Hoa5xzBfk/XNXfnhaRV690Q80ogiwgQxxwI2MqMR0tw6zKQ42wWm+3slGFEiadVvZQpY1Am9+Upg/aHP2WhoyXi4HzhhCsaSS91w57EoJbzXgwKol2WjtMZKuSryigBIzKiF0Us7+6DKKdmpqGCYcPFR9RSYygwMk/L X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123562025)(20161123564025)(20161123555025)(20161123560025)(20161123558021)(6072148);SRVR:BL2PR07MB2338;BCL:0;PCL:0;RULEID:;SRVR:BL2PR07MB2338; X-Microsoft-Exchange-Diagnostics: 1;BL2PR07MB2338;4:psExEao8I1XHc/k2lVX2afNzlb9z+yRtNNpyLC6Xat2IUkrAUSnbXZece5YTyzxSizaW26IEF2c7/EWPpz8iFM31ojxqgqC9abxCH+8z/2v9FphrKmuJdsLS3iUANz6H2mSfe0+ASnBw+UD5fjj7tFC6GKuvC7yshuh2wjcWGpPauBViG8naau4nFgmJtE94RUsJQTPlecaeY4K1RwzD/rI8POjYz5JojzSsG12jUkCMGDJRH5xhBMSWC3LFJenFRZj0L4SFv7H0wLqOMZCyJnqEUeHopEEbCEeD6C8TneSTk9tDA81fwnGWgFYMuqldH6Coh6HK92ElAle+wHkcTk6p+eT/sxqTAH7UxGzRvWEUIwNGtnbf5+yWLNc3MUtCgshPFO2/GDQ1ZRYOO9AInqS8j6FocgQ7aYMP14sxCDujOkd1KeQy4T9kI7jGUCJ6E162XG1sQkYevf/TJQQ5c2Mq1tDgiIsUEgdYc6i8YqAuujSIFyXnRwjaM0WjyYSXF3Y7uWMFagsKGWtQwbDfSNEybyS5S7hRQY1BumBkfkgU1Oo5L/B/PieuK1pUP9z1mViz6RYzUa95oBug6tHpQDUpesyHyXqINppyK/hQ8jk= X-Forefront-PRVS: 018577E36E X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(189002)(199003)(24454002)(4001350100001)(97736004)(54356999)(46406003)(76176999)(50986999)(189998001)(101416001)(2906002)(4326007)(47776003)(83506001)(66066001)(86362001)(50466002)(110136003)(561944003)(38730400001)(33656002)(6506006)(55016002)(6916009)(229853002)(305945005)(54906002)(42186005)(25786008)(6666003)(97756001)(7736002)(2950100002)(68736007)(23726003)(3846002)(6116002)(1076002)(81166006)(9686003)(81156014)(8676002)(5660300001)(106356001)(105586002)(92566002)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2PR07MB2338;H:rric.localdomain;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BL2PR07MB2338;23:QREuI7i8sSYwk6ZjG5PNlZN8xpXq9lDqPBcKssWmx?= =?us-ascii?Q?cEwcUmlsgd4PU9daST/NbAvQrw4m7A+505p5XEK6G+epRBmVlI/1FnztBqlv?= =?us-ascii?Q?QDnvm1RSPfJiw6W/nS0arpl4VlISYnWpsig9oiPka2kPyZRhLBUwjYH6zzNP?= =?us-ascii?Q?HQWv2lAQUpXKcyr3Ilvb5mPNoBvtxY4BKGJ1czrGkfJ00B2Zea1WGixb1fJs?= =?us-ascii?Q?fFcsePxgRAI7P4IxyCrV2jlhaOogw1MJBaxOdNM8OQSd/pe2hXQqmVGWsULM?= =?us-ascii?Q?7l6bhkAwdgUwlwAxJ+fWXWMXdPhwyaIAKp5ggmIc029q0hSRb4QQ2/I7M/Sm?= =?us-ascii?Q?s+5UkYzjx5kSX2a/Dctr+iZTULjs/3boo9iygI2iepRq3UoBvRpLj6PRxo4Q?= =?us-ascii?Q?O13kbzo+hKZ84J9U9i3jJNylDDoLWb8pXgJlOorsTgPVpwqvW1uHDc8OkQF4?= =?us-ascii?Q?3TEmgUggLLpIX02WZIRVzCFGNyCEmWSowll+Z8/dxwwGJUZ6wUQibVo8ORQX?= =?us-ascii?Q?X2RwoGMTaTNojRqMF7r2TgawX4c++T+M1kEwUP4gb1ORTXDJMZ+8lOXH6fMW?= =?us-ascii?Q?8PsQkahXfCWCayxdldXX9iXbBVJWwwLIGiwJ+eshI74Tqz4r+dWDKt7K48WC?= =?us-ascii?Q?LzEn1+X6EBGK8x3XwNPPGO3/fr/TMc1yuehMsAYNegRIP00gqod4xpfGV+9f?= =?us-ascii?Q?vBBNEU1B7szfuSYTmLsIxz96dHlo4oFDsN8VYG61Jamy4L1zI498P4aeMglJ?= =?us-ascii?Q?zITsjyyAXu11lG+Fplf0C4b0Pv4BSCRlr8B7Lgu7B4Yee1aSy5e9YJxmSzdh?= =?us-ascii?Q?DpSnw0nqvljKoTaSvcZlOd8Gg0L9LM5ZGW5kstMU6iz2g8Uc2yLfcEDZBpIv?= =?us-ascii?Q?Xlgv3LYdjcF1AbQHlQ0InpeREsg6tptGJwW20dyj0QvITm03c5jKDUrsBDOs?= =?us-ascii?Q?7Lp4IjN/A6Y04pdEiUd6lSkmVdSikZVXPd6I7IrLYDl4Oo/FEKVN5fntUtGb?= =?us-ascii?Q?rC+qaT/Josdf6wN75U876jJt9B8HwNjfwWvItg6SeR4TY82cRxthVFobknOZ?= =?us-ascii?Q?vMcnda+T4+YCy9iVbrgzaywgjevUTR9Hxv9zByoLN9+Nr8klGBEmnqE3SN6p?= =?us-ascii?Q?9mrSOUx7lEKWpX/HExT4h+wY/iAqDYe/5iFi4Kf7IHDHjB7YfL/s4EjaRN9p?= =?us-ascii?Q?+NjgOfaIIqMUh6Gcc981jLW0vw4OCoPklaV0pC4rjfF1cDrLUVFMH5Lzo9Cb?= =?us-ascii?Q?ZfA6Eq5wg71pfSqH6I=3D?= X-Microsoft-Exchange-Diagnostics: 1;BL2PR07MB2338;6:c1yDL+4sIKRr4PtWjOuf0fIE7l70DkBfjTQVI41U+laDz9m2np6bjWiKW9t6jkwZ9ylYD+EfOZ7P0Iu88RjXOROEvwWSm5o8VrS6Y9II0ffmdYRMOHU66AcJ3fqB2iX7NEovP9X/vY9e8vw69cJFkcpNkKW59VTSPl4sfbo81lYfhz+0GtvySIZM5DXLRWiEB6+WORM1MP7CjvnTAWFL4nS8iksnHjkUqBhuex1ar80fYTy7JAGeZLA7/r84DgffqpXxQyP4Ez6db0SZidKmxYgEWh+mnJ8uRU5Hq2TDJqgvTo6ptyxGYcAwpZuburbCEFdV2MCgtCECzKxvpwMYaQzVqKS1KkJDVahoxNI56zUsn2cb+qM0ScpV2UevctBu/F6gUBublegiea3nsrQp6jIjbNvWteoeFQ3mPm7ODTI=;5:5eqDbdPUVxa1xm+y8E3nNnw6/Z2VmEUfhe6IoyfS3sb4BIg8q+NbtmJRfMrmZx1egrz2N67Vsc5WXkHKCMkNnYrQphjXYiTO9eTKTuKv/o04k2EYpdUOSHm6QSHd8cyPM4wkLxOEBqXKI34P56MwcWfGIxsCGK0kl8iVpgiIUDE=;24:+Mb52FcC5hCHZW0VuWN5INnZ4YQGbwy9g54QyllqoE8gS+2OsREo9gHycBfmJKP7nmmf4GRJP0Kt7XwCsOIp3a3gIsyJVyLx7gKrw2d7bN4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BL2PR07MB2338;7:tZnkJde2P08nSFs0LHsO8txdH2/5uy8ZgzfiDyQygI/FkFn9zumEsvD6SwLuPggzTU9EoAFr1h3CUSyyC6m5ISlTD2lyi61W6r8veO5apbNFGCbDpO1vxMfQJJIHaKp7PhB9aJREvzuWHdhR5obBg9oW4cLa0Hl7g/zOK7YglThV1qURuPqBm79ospGLNt+Gr5t7gX0bn2jqQ5AIC7dND1wIEv8tgJM+3oXiCLoCDXLILGMax1OtnSEM+rSlBY1ZfcTq1deZ+DZ9PySoDxmCwcp3IqRJ8ifC97Xjmb+4PPEl70UN26BylkeLzFPLlNInmmi7O6CsbaXMM6yHKrQgfnmgVuq2AaZD7c9mhSWrpBEOf8z6ery1wjqFBmXrJAJ4zfEjxaSg5KwoI7Yc6sxWMGV8k3AWCxj/FrKDsWwzkopF8UNxAMsKvt/3UfKl0mfB4YViDz/lfIxf7VtwKTHAVA== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2017 18:41:54.1015 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR07MB2338 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12.01.17 15:33:15, Will Deacon wrote: > On Wed, Jan 11, 2017 at 01:11:42PM +0100, Robert Richter wrote: > > Definition of cpu ranges are hard to read if the cpu variant is not > > zero. Provide MIDR_CPU_FULL_REV() macro to describe the full hardware > > revision of a cpu including variant and (minor) revision. > > > > Signed-off-by: Robert Richter > > --- > > arch/arm64/include/asm/cputype.h | 3 +++ > > arch/arm64/kernel/cpu_errata.c | 15 +++++++++------ > > arch/arm64/kernel/cpufeature.c | 8 +++----- > > 3 files changed, 15 insertions(+), 11 deletions(-) > > > > diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h > > index 26a68ddb11c1..983e59cbdd54 100644 > > --- a/arch/arm64/include/asm/cputype.h > > +++ b/arch/arm64/include/asm/cputype.h > > @@ -56,6 +56,9 @@ > > (0xf << MIDR_ARCHITECTURE_SHIFT) | \ > > ((partnum) << MIDR_PARTNUM_SHIFT)) > > > > +#define MIDR_CPU_FULL_REV(var, rev) \ > > + (((var) << MIDR_VARIANT_SHIFT) | (rev)) > > Minor nit, but could you rename this to MIDR_CPU_VAR_REV instead please? > The revision field *is* the bottom 4 bits, so "full" rev doesn't really > make a lot of sense. Yeah, this is that I had in my first version. I wasn't sure on the naming, so I am fine with your proposal. Will resubmit. Thanks, -Robert