From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751019AbdALSvw (ORCPT ); Thu, 12 Jan 2017 13:51:52 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:46548 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751008AbdALSuQ (ORCPT ); Thu, 12 Jan 2017 13:50:16 -0500 Date: Thu, 12 Jan 2017 11:50:05 -0700 From: Jason Gunthorpe To: "Maciej S. Szmigiero" Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel , Peter Huewe , Marcel Selhorst , Jarkko Sakkinen , Christophe Ricard Subject: Re: [PATCH] tpm_tis: fix iTPM probe via probe_itpm() function Message-ID: <20170112185005.GC12836@obsidianresearch.com> References: <6bd0d2fe-f979-a4dc-7c4d-54036f4d37f8@maciej.szmigiero.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6bd0d2fe-f979-a4dc-7c4d-54036f4d37f8@maciej.szmigiero.name> User-Agent: Mutt/1.5.24 (2015-08-30) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.156 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 12, 2017 at 07:12:06PM +0100, Maciej S. Szmigiero wrote: > probe_itpm() function is supposed to send command without an itpm flag set > and if this fails to repeat it, this time with the itpm flag set. > > However, commit 41a5e1cf1fe15 ("tpm/tpm_tis: Split tpm_tis driver into a > core and TCG TIS compliant phy") moved the itpm flag from an "itpm" > variable to a TPM_TIS_ITPM_POSSIBLE chip flag, so setting the > (now function-local) itpm variable no longer had any effect. > > Finally, this function-local itpm variable was removed by > commit 56af322156dbe9 ("tpm/tpm_tis: remove unused itpm variable") > > Tested only on non-iTPM TIS TPM. > > Signed-off-by: Maciej S. Szmigiero could you also change the name of TPM_TIS_ITPM_POSSIBLE to TPM_TIS_ITPM_WORKAROUND ? Reviewed-by: Jason Gunthorpe Jason