From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750851AbdALUTJ (ORCPT ); Thu, 12 Jan 2017 15:19:09 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:35380 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750762AbdALUTI (ORCPT ); Thu, 12 Jan 2017 15:19:08 -0500 Date: Thu, 12 Jan 2017 13:19:02 -0700 From: Jason Gunthorpe To: "Maciej S. Szmigiero" Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel , Peter Huewe , Marcel Selhorst , Jarkko Sakkinen , Christophe Ricard Subject: Re: [PATCH] tpm_tis: override reported C and D timeouts for Atmel 3203 Message-ID: <20170112201902.GA15687@obsidianresearch.com> References: <08953fb6-c332-ef29-2614-6335570023be@maciej.szmigiero.name> <20170112184229.GB12836@obsidianresearch.com> <259e1606-255b-5bf4-54bb-1bed967c228a@maciej.szmigiero.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <259e1606-255b-5bf4-54bb-1bed967c228a@maciej.szmigiero.name> User-Agent: Mutt/1.5.24 (2015-08-30) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.156 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 12, 2017 at 09:09:33PM +0100, Maciej S. Szmigiero wrote: > Hmm, I dug in history of tpm-interface.c and the code had actually rejected > zero timeouts until commit 8e54caf407b98e (this is the commit that > introduced the Atmel 3204 workaround) and let default timeout values remain > instead (it looks like they were exactly like these in above override at > that time). The model changed around then.. Just printing if the timeout is 0 is enough for now.. > Did Atmel 3204 report wrong but non-zero timeouts? Yes, I think it may have.. Jason