From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751236AbdAMIKb (ORCPT ); Fri, 13 Jan 2017 03:10:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52652 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751157AbdAMIKa (ORCPT ); Fri, 13 Jan 2017 03:10:30 -0500 Date: Fri, 13 Jan 2017 16:10:23 +0800 From: Dave Young To: Ard Biesheuvel Cc: Matt Fleming , "linux-efi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" , Nicolai Stange , Ingo Molnar , Thomas Gleixner , "hpa@zytor.com" , Dan Williams , Mika =?iso-8859-1?Q?Penttil=E4?= , bhsharma@redhat.com Subject: Re: [PATCH 1/4] efi/x86: make efi_memmap_reserve only insert into boot mem areas Message-ID: <20170113081015.GA5328@dhcp-128-65.nay.redhat.com> References: <20170112094118.815108042@redhat.com> <20170112094214.860924858@redhat.com> <20170112211953.GA2709@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170112211953.GA2709@dhcp-128-65.nay.redhat.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 13 Jan 2017 08:10:30 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/13/17 at 05:20am, Dave Young wrote: > On 01/12/17 at 04:15pm, Ard Biesheuvel wrote: > > Hello Dave, > > > > On 12 January 2017 at 09:41, Dave Young wrote: > > > There are memory ranges like below when I testing early efi_mem_reserve: > > > > > > efi: mem62: [Reserved | | | | | | | | | | | | ] range=[0x0000000000000000-0xffffffffffffffff] (0MB) > > > efi: mem63: [Reserved | | | | | | | | | | | | ] range=[0x0000000000000000-0xffffffffffffffff] (0MB) > > > efi: mem64: [Reserved | | | | | | | | | | | | ] range=[0x0000000000000000-0xffffffffffffffff] (0MB) > > > efi: mem65: [Reserved | | | | | | | | | | | | ] range=[0x0000000000000000-0xffffffffffffffff] (0MB) > > > efi: mem66: [Reserved | | | | | | | | | | | | ] range=[0x0000000000000000-0xffffffffffffffff] (0MB) > > > efi: mem67: [Reserved | | | | | | | | | | | | ] range=[0x0000000000000000-0xffffffffffffffff] (0MB) > > > > > > > Did you spot Peter's patch to prune invalid memmap entries? > > > > https://git.kernel.org/cgit/linux/kernel/git/efi/efi.git/commit/?h=next&id=b2a91a35445229 > > > > I would expect this patch to no longer be necessary with that in place, no? > > Ard, good suggestion, I did not notice that patch, will try. Actually > I'm not sure about fake_mem handling, if we can filter out the invalid > ranges then it will be natural to drop this one after a test. The commit works for me. I updated the series. I addressed comments known, moved patch 1 to 4/4 with only boot service (dropped loader areas checking), I plan to send them out next Monday see if there are more comments. If anyone who want to try them now, feel free to download from below url: http://people.redhat.com/~ruyang/efi-bgrt/ Thanks Dave