From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751660AbdAMNLU (ORCPT ); Fri, 13 Jan 2017 08:11:20 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:35106 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751526AbdAMNLT (ORCPT ); Fri, 13 Jan 2017 08:11:19 -0500 Date: Fri, 13 Jan 2017 15:11:12 +0200 From: Krzysztof Kozlowski To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Laxman Dewangan , Krzysztof Kozlowski , Chanwoo Choi , Bartlomiej Zolnierkiewicz , Lee Jones Subject: Re: [PATCH 3/4] mfd: max77686: Use the struct i2c_driver .probe_new instead of .probe Message-ID: <20170113131112.axiqyn23ldnoav4l@kozik-lap> References: <1484228857-20182-1-git-send-email-javier@osg.samsung.com> <1484228857-20182-4-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1484228857-20182-4-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 12, 2017 at 10:47:36AM -0300, Javier Martinez Canillas wrote: > If a driver is only used in DT platforms, there's no need to get the > i2c_device_id as an argument of the probe function. Since this data > can be get from the matching of_device_id. > > There's a temporary .probe_new field in struct i2c_driver that can be > used as probe callback for the case when i2c_device_id won't be used. > > Signed-off-by: Javier Martinez Canillas > --- > > drivers/mfd/max77686.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Krzysztof Kozlowski Tested-by: Krzysztof Kozlowski Best regards, Krzysztof