From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751893AbdAMNVq (ORCPT ); Fri, 13 Jan 2017 08:21:46 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:54462 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751780AbdAMNVo (ORCPT ); Fri, 13 Jan 2017 08:21:44 -0500 From: Colin King To: Linus Walleij , Lokesh Vutla , Tony Lindgren , Nishanth Menon , linux-gpio@vger.kernel.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH] pinctrl: remove redundant pin < 0 check on unsigned int Date: Fri, 13 Jan 2017 13:20:39 +0000 Message-Id: <20170113132039.19830-1-colin.king@canonical.com> X-Mailer: git-send-email 2.10.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King pin is an unsigned int and therefore can never be < 0 so this check is redudant. Remove the check and the associated dev_err error message. Fixes CoverityScan CID#1396438 ("Unsigned compared against 0") Signed-off-by: Colin Ian King --- drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c index 3b86d3d..a345166 100644 --- a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c +++ b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c @@ -665,12 +665,6 @@ static void ti_iodelay_pin_dbg_show(struct pinctrl_dev *pctldev, r = iod->reg_data; offset = ti_iodelay_pin_to_offset(iod, pin); - if (pin < 0) { - dev_err(iod->dev, "invalid pin offset for pin%i\n", pin); - - return; - } - pd = &iod->pa[pin]; cfg = pd->drv_data; -- 2.10.2