From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752129AbdAMP4G (ORCPT ); Fri, 13 Jan 2017 10:56:06 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:45182 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751880AbdAMP4F (ORCPT ); Fri, 13 Jan 2017 10:56:05 -0500 Date: Fri, 13 Jan 2017 16:55:53 +0100 From: Alexandre Belloni To: Russell King - ARM Linux Cc: Arnd Bergmann , Alessandro Zummo , Amelie Delaunay , Alexandre Torgue , Mathieu Poirier , linux-kernel@vger.kernel.org, Mark Brown , Maxime Coquelin , rtc-linux@googlegroups.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/3] rtc: stm32: use 32-bit cast for BIT() macro Message-ID: <20170113155553.gjxfxpald3sqcywi@piout.net> References: <20170113153311.2611510-1-arnd@arndb.de> <20170113153311.2611510-3-arnd@arndb.de> <20170113155229.GS14217@n2100.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170113155229.GS14217@n2100.armlinux.org.uk> User-Agent: NeoMutt/20161126 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/01/2017 at 15:52:29 +0000, Russell King - ARM Linux wrote : > On Fri, Jan 13, 2017 at 04:32:53PM +0100, Arnd Bergmann wrote: > > -#define PWR_CR_DBP BIT(8) > > +#define PWR_CR_DBP (u32)BIT(8) > > Shouldn't that have parens around it as it's no longer a simple expression. > Yes, at least checkpatch complains about it. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com