From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750960AbdAMQzE (ORCPT ); Fri, 13 Jan 2017 11:55:04 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:46974 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750768AbdAMQzD (ORCPT ); Fri, 13 Jan 2017 11:55:03 -0500 Date: Fri, 13 Jan 2017 17:54:51 +0100 From: Alexandre Belloni To: Arnd Bergmann Cc: Alessandro Zummo , Maxime Coquelin , Alexandre Torgue , Amelie Delaunay , Mathieu Poirier , rtc-linux@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] rtc: stm32: remove __exit annotation on remove callback Message-ID: <20170113165451.3wsyynukd3su2tcf@piout.net> References: <20170113153311.2611510-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170113153311.2611510-1-arnd@arndb.de> User-Agent: NeoMutt/20161126 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/01/2017 at 16:32:51 +0100, Arnd Bergmann wrote : > The remove function can be called at runtime for a manual 'unbind' > operation and must not be left out from a built-in driver, as kbuild > complains: > > `stm32_rtc_remove' referenced in section `.data.stm32_rtc_driver' of drivers/rtc/rtc-stm32.o: defined in discarded section `.exit.text' of drivers/rtc/rtc-stm32.o > > This removes the extraneous annotation. > > Fixes: 4e64350f42e2 ("rtc: add STM32 RTC driver") > Signed-off-by: Arnd Bergmann > --- > drivers/rtc/rtc-stm32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com