From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751236AbdAMQ4y (ORCPT ); Fri, 13 Jan 2017 11:56:54 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:37672 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750793AbdAMQ4l (ORCPT ); Fri, 13 Jan 2017 11:56:41 -0500 From: Daniel Thompson To: Andrew Morton Cc: Daniel Thompson , linux-mm@kvack.org, linux-kernel@vger.kernel.org, patches@linaro.org Subject: [PATCH] tools/vm: Add missing Makefile rules Date: Fri, 13 Jan 2017 16:56:30 +0000 Message-Id: <20170113165630.27541-1-daniel.thompson@linaro.org> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170113164948.25588-1-daniel.thompson@linaro.org> References: <20170113164948.25588-1-daniel.thompson@linaro.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently the tools/vm Makefile has a rather arbitrary implicit build rule; page-types is the first value in TARGETS so lets just build that one! Additionally there is no install rule and this is needed for make -C tools vm_install to work properly. Provide a more sensible implicit build rule and a new install rule. Note that the variables names used by the install rule (DESTDIR and sbindir) are copied from prior-art in tools/power/cpupower. Signed-off-by: Daniel Thompson --- Notes: This is a resend with the linux-mm list spelled correctly (and with special apologies to Andrew for the spam). tools/vm/Makefile | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tools/vm/Makefile b/tools/vm/Makefile index 93aadaf7ff63..006029456988 100644 --- a/tools/vm/Makefile +++ b/tools/vm/Makefile @@ -9,6 +9,8 @@ CC = $(CROSS_COMPILE)gcc CFLAGS = -Wall -Wextra -I../lib/ LDFLAGS = $(LIBS) +all: $(TARGETS) + $(TARGETS): $(LIBS) $(LIBS): @@ -20,3 +22,9 @@ $(LIBS): clean: $(RM) page-types slabinfo page_owner_sort make -C $(LIB_DIR) clean + +sbindir ?= /usr/sbin + +install: all + install -d $(DESTDIR)$(sbindir) + install -m 755 -p $(TARGETS) $(DESTDIR)$(sbindir) -- 2.9.3