From: Tobias Klauser <tklauser@distanz.ch>
To: Shyam Saini <mayhs11saini@gmail.com>
Cc: hariprasad@chelsio.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cxgb4: Remove redundant memset before memcpy
Date: Sat, 14 Jan 2017 13:27:40 +0100 [thread overview]
Message-ID: <20170114122739.GG1201@distanz.ch> (raw)
In-Reply-To: <1484356660-19082-1-git-send-email-mayhs11saini@gmail.com>
On 2017-01-14 at 02:17:40 +0100, Shyam Saini <mayhs11saini@gmail.com> wrote:
> The region set by the call to memset, immediately overwritten by
> the subsequent call to memcpy and thus makes the memset redundant.
>
> Also remove the memset((&info, 0, sizeof(info)) on line 398 because
> info is memcpy()'ed to before being used in the loop and it isn't
> used outside of the loop.
>
> Signed-off-by: Shyam Saini <mayhs11saini@gmail.com>
Reviewed-by: Tobias Klauser <tklauser@distanz.ch>
next prev parent reply other threads:[~2017-01-14 12:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-14 1:17 Shyam Saini
2017-01-14 12:27 ` Tobias Klauser [this message]
2017-01-14 17:00 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2017-01-13 9:52 Shyam Saini
2017-01-13 15:57 ` Tobias Klauser
2017-01-14 0:55 ` Shyam Saini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170114122739.GG1201@distanz.ch \
--to=tklauser@distanz.ch \
--cc=hariprasad@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mayhs11saini@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®