mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Kartikey Singh <dr.kartikeynrc@gmail.com>
Cc: insafonov@gmail.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: staging: rtl8188eu: include: wifi: Unnecessary do-while removed from macro
Date: Sat, 14 Jan 2017 19:38:01 +0100	[thread overview]
Message-ID: <20170114183801.GA27644@kroah.com> (raw)
In-Reply-To: <20170114182336.ekexr4mluquurd63@kartikey-HP-Notebook>

On Sat, Jan 14, 2017 at 11:53:36PM +0530, Kartikey Singh wrote:
> do while loop removed from single statement macro
> 
> Signed-off-by: Kartikey Singh <dr.kartikeynrc@gmail.com>
> ---
>  drivers/staging/rtl8188eu/include/wifi.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/include/wifi.h b/drivers/staging/rtl8188eu/include/wifi.h
> index 9e08e68..57db709 100644
> --- a/drivers/staging/rtl8188eu/include/wifi.h
> +++ b/drivers/staging/rtl8188eu/include/wifi.h
> @@ -481,9 +481,7 @@ static inline int IsFrameTypeCtrl(unsigned char *pframe)
>  ------------------------------------------------------------------------------*/
>  
>  #define SetOrderBit(pbuf)	\
> -	do	{	\
> -		*(unsigned short *)(pbuf) |= cpu_to_le16(_ORDER_); \
> -	} while (0)
> +	(*(unsigned short *)(pbuf) |= cpu_to_le16(_ORDER_))

This macro is never used, so it could just be removed, right?

>  #define GetOrderBit(pbuf)			\
>  	(((*(unsigned short *)(pbuf)) & le16_to_cpu(_ORDER_)) != 0)

Same with that one.  Care to do that type of fixup instead please?

thanks,

greg k-h

  reply	other threads:[~2017-01-14 18:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-14 18:23 Kartikey Singh
2017-01-14 18:38 ` Greg KH [this message]
2017-01-14 19:38   ` Kartikey Singh
2017-01-15 10:56     ` Greg KH
     [not found]   ` <CAOKLEkBoQrV_TE+61vD=43B8py21Moq-Tyczz+d=u8dTpbACkg@mail.gmail.com>
2017-01-14 19:40     ` Greg KH
2017-01-14 19:53       ` Ivan Safonov
2017-01-15 10:56         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170114183801.GA27644@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=dr.kartikeynrc@gmail.com \
    --cc=insafonov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®