From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751894AbdANSit (ORCPT ); Sat, 14 Jan 2017 13:38:49 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:41158 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751394AbdANSir (ORCPT ); Sat, 14 Jan 2017 13:38:47 -0500 Date: Sat, 14 Jan 2017 19:39:00 +0100 From: Greg KH To: Kartikey Singh Cc: insafonov@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: staging: rtl8188eu: include: Fix semicolon after macro definition Message-ID: <20170114183900.GB27644@kroah.com> References: <20170114181756.mhnb3jmsscamsnhs@kartikey-HP-Notebook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170114181756.mhnb3jmsscamsnhs@kartikey-HP-Notebook> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 14, 2017 at 11:47:56PM +0530, Kartikey Singh wrote: > fixed a trailing semicolon after macro definition > > Signed-off-by: Kartikey Singh > --- > drivers/staging/rtl8188eu/include/basic_types.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8188eu/include/basic_types.h b/drivers/staging/rtl8188eu/include/basic_types.h > index 69c4d49..cbd6f92 100644 > --- a/drivers/staging/rtl8188eu/include/basic_types.h > +++ b/drivers/staging/rtl8188eu/include/basic_types.h > @@ -128,7 +128,7 @@ value to host byte ordering.*/ > ( \ > LE_BITS_CLEARED_TO_2BYTE(__pstart, __bitoffset, __bitlen) | \ > ((((u16)__val) & BIT_LEN_MASK_16(__bitlen)) << (__bitoffset)) \ > - ); > + ) This macro, and others in this file, are also never used, can you just remove them too? thanks, greg k-h