From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750929AbdAPRgV (ORCPT ); Mon, 16 Jan 2017 12:36:21 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:44856 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750770AbdAPRgT (ORCPT ); Mon, 16 Jan 2017 12:36:19 -0500 Date: Mon, 16 Jan 2017 12:36:17 -0500 (EST) Message-Id: <20170116.123617.1891198374111644473.davem@davemloft.net> To: stephen@networkplumber.org Cc: tremyfr@gmail.com, mlindner@marvell.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: marvell: skge: use new api ethtool_{get|set}_link_ksettings From: David Miller In-Reply-To: <20170116092951.3b577463@xeon-e3> References: <1484395708-4107-1-git-send-email-tremyfr@gmail.com> <20170116092951.3b577463@xeon-e3> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 16 Jan 2017 08:37:12 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stephen Hemminger Date: Mon, 16 Jan 2017 09:29:51 -0800 > On Sat, 14 Jan 2017 13:08:28 +0100 > Philippe Reynes wrote: > >> The ethtool api {get|set}_settings is deprecated. >> We move this driver to new api {get|set}_link_ksettings. >> >> The callback set_link_ksettings no longer update the value >> of advertising, as the struct ethtool_link_ksettings is >> defined as const. >> >> Signed-off-by: Philippe Reynes > > Did you test this on real hardware? Philippe probably doesn't have physical access to most of the drivers he is converting. But, he is the only person working on converting all of the drivers, and therefore when the change looks straightforward I am going to reward his work and effort by applying his changes and hope there isn't any fallout. Those who really care can test his patches and give a Tested-by: Thanks.