From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751468AbdAPAEj (ORCPT ); Sun, 15 Jan 2017 19:04:39 -0500 Received: from mail-io0-f194.google.com ([209.85.223.194]:35114 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751122AbdAPAEi (ORCPT ); Sun, 15 Jan 2017 19:04:38 -0500 Date: Sun, 15 Jan 2017 19:04:30 -0500 From: Tejun Heo To: Zefan Li Cc: hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHSET for-4.11] cgroup: avoid spurious identity ->*attach() invocations Message-ID: <20170116000430.GG14446@mtj.duckdns.org> References: <20161229221115.31995-1-tj@kernel.org> <58760D09.9010508@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58760D09.9010508@huawei.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 11, 2017 at 06:46:33PM +0800, Zefan Li wrote: > On 2016/12/30 6:11, Tejun Heo wrote: > > Hello, > > > > On the v2 hierarchy, when controllers are enabled and disabled, other > > ->*attach() callbacks of other controllers are called spuriously with > > the same source and destination. While this isn't critical, it's a > > bit nasty and can lead to temporary double charging on certain > > controllers. This patchset fixes the issue. > > > > This patchset contains the following three patches. > > > > 0001-cgroup-cosmetic-update-to-cgroup_taskset_add.patch > > 0002-cgroup-track-migration-context-in-cgroup_mgctx.patch > > 0003-cgroup-call-subsys-attach-only-for-subsystems-which-.patch > > > > 0001-0002 restructures migration context tracking so that extra state > > can be tracked easily. 0003 fixes the spurious ->*attach() > > invocations. > > > > This patchset is also available in the following git branch. > > > > git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-avoid-identity-attach > > > > diffstat follows. > > > > kernel/cgroup/cgroup-internal.h | 69 +++++++++++++++-- > > kernel/cgroup/cgroup-v1.c | 10 +- > > kernel/cgroup/cgroup.c | 161 ++++++++++++++++------------------------ > > 3 files changed, 135 insertions(+), 105 deletions(-) > > > > Acked-by: Zefan Li Applied to cgroup/for-4.11. Thanks. -- tejun