From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751064AbdAPDf5 (ORCPT ); Sun, 15 Jan 2017 22:35:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47184 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750848AbdAPDfy (ORCPT ); Sun, 15 Jan 2017 22:35:54 -0500 Date: Mon, 16 Jan 2017 09:05:50 +0530 From: Amit Shah To: "G. Campana" Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] virtio_console: fix a crash in config_work_handler Message-ID: <20170116033550.GK16209@amit-lp.rh> References: <1484390319-5252-1-git-send-email-gcampana@quarkslab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484390319-5252-1-git-send-email-gcampana@quarkslab.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 16 Jan 2017 03:35:55 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (Sat) 14 Jan 2017 [11:38:39], G. Campana wrote: > Using control_work instead of config_work as the 3rd argument to > container_of results in an invalid portdev pointer. Indeed, the work > structure is initialized as below: > > INIT_WORK(&portdev->config_work, &config_work_handler); > > It leads to a crash when portdev->vdev is dereferenced later. This bug > is triggered when the guest uses a virtio-console without multiport > feature and receives a config_changed virtio interrupt. Thanks, the patch is fine, but needs signed-off-by. Please also post to virtualization@lists.linux-foundation.org Amit