From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751459AbdAPHfr (ORCPT ); Mon, 16 Jan 2017 02:35:47 -0500 Received: from mx2.suse.de ([195.135.220.15]:44164 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbdAPHfp (ORCPT ); Mon, 16 Jan 2017 02:35:45 -0500 Date: Mon, 16 Jan 2017 08:35:41 +0100 From: Michal Hocko To: David Rientjes Cc: Johannes Weiner , Andrew Morton , Vladimir Davydov , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch v2] mm, memcg: do not retry precharge charges Message-ID: <20170116073540.GB7981@dhcp22.suse.cz> References: <20170113084014.GB25212@dhcp22.suse.cz> <20170114162238.GD26139@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat 14-01-17 21:42:48, David Rientjes wrote: > On Sat, 14 Jan 2017, Johannes Weiner wrote: > > > The OOM killer livelock was the motivation for this patch. With that > > ruled out, what's the point of this patch? Try a bit less hard to move > > charges during task migration? > > > > Most important part is to fail ->can_attach() instead of oom killing > processes when attaching a process to a memcg hierarchy. But we are not invoking the oom killer from this path even without __GFP_NORETRY. Or am I missing your point? -- Michal Hocko SUSE Labs