From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751162AbdAPJiY (ORCPT ); Mon, 16 Jan 2017 04:38:24 -0500 Received: from mga03.intel.com ([134.134.136.65]:35899 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750874AbdAPJiV (ORCPT ); Mon, 16 Jan 2017 04:38:21 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,238,1477983600"; d="scan'208";a="53508901" Date: Mon, 16 Jan 2017 11:38:16 +0200 From: Jarkko Sakkinen To: Stefan Berger Cc: Nayna Jain , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [tpmdd-devel] [PATCH v8 2/2] tpm: add securityfs support for TPM 2.0 firmware event log Message-ID: <20170116093816.7pzmpmcmlj4t5zr6@intel.com> References: <1484121262-25732-1-git-send-email-nayna@linux.vnet.ibm.com> <1484121262-25732-3-git-send-email-nayna@linux.vnet.ibm.com> <9c605b61-bd5f-eb74-8fc0-ac3587852808@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9c605b61-bd5f-eb74-8fc0-ac3587852808@linux.vnet.ibm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 13, 2017 at 01:09:29PM -0500, Stefan Berger wrote: > On 01/11/2017 02:54 AM, Nayna Jain wrote: > > Unlike the device driver support for TPM 1.2, the TPM 2.0 does > > not support the securityfs pseudo files for displaying the > > firmware event log. > > > > This patch enables support for providing the TPM 2.0 event log in > > binary form. TPM 2.0 event log supports a crypto agile format that > > records multiple digests, which is different from TPM 1.2. This > > patch enables the tpm_bios_log_setup for TPM 2.0 and adds the > > event log parser which understand the TPM 2.0 crypto agile format. > > > > Signed-off-by: Nayna Jain > > --- > > drivers/char/tpm/Makefile | 2 +- > > .../char/tpm/{tpm_eventlog.c => tpm1_eventlog.c} | 35 ++-- > > drivers/char/tpm/tpm2_eventlog.c | 203 +++++++++++++++++++++ > > drivers/char/tpm/tpm_acpi.c | 3 + > > drivers/char/tpm/tpm_eventlog.h | 63 +++++++ > > 5 files changed, 291 insertions(+), 15 deletions(-) > > rename drivers/char/tpm/{tpm_eventlog.c => tpm1_eventlog.c} (95%) > > create mode 100644 drivers/char/tpm/tpm2_eventlog.c > > > > > > diff --git a/drivers/char/tpm/tpm_acpi.c b/drivers/char/tpm/tpm_acpi.c > > index b7718c9..169edf3 100644 > > --- a/drivers/char/tpm/tpm_acpi.c > > +++ b/drivers/char/tpm/tpm_acpi.c > > @@ -54,6 +54,9 @@ int tpm_read_log_acpi(struct tpm_chip *chip) > > u64 len, start; > > struct tpm_bios_log *log; > > > > + if (chip->flags & TPM_CHIP_FLAG_TPM2) > > + return -ENODEV; > > + > > > Works with SeaBIOS when this check is disabled. What about OF call paths? > Stefan /Jarkko