From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: tpmdd-devel@lists.sourceforge.net,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] tpm: Check size of response before accessing data
Date: Mon, 16 Jan 2017 15:25:12 +0200 [thread overview]
Message-ID: <20170116132512.zyzt4gflticb6xz2@intel.com> (raw)
In-Reply-To: <20170116132409.i2y7ipchsohqfqxz@intel.com>
On Mon, Jan 16, 2017 at 03:24:09PM +0200, Jarkko Sakkinen wrote:
> On Fri, Jan 13, 2017 at 09:36:34PM -0500, Stefan Berger wrote:
> > Make sure that we have not received less bytes than what is indicated
> > in the header of the TPM response. Also, check the number of bytes in
> > the response before accessing its data.
> >
> > Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
>
> There are some things that I want to comment after all but I can give
> now
>
> Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>
> I also noticed that this patch is not CC'd to linux-kernel.
Please go through the whole patch and remove arithmetic
from every possible place where you only end up with a
constant.
/Jarkko
next prev parent reply other threads:[~2017-01-16 13:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1484361394-13581-1-git-send-email-stefanb@linux.vnet.ibm.com>
2017-01-16 13:24 ` Jarkko Sakkinen
2017-01-16 13:25 ` Jarkko Sakkinen [this message]
2017-01-16 15:38 ` Stefan Berger
2017-01-16 14:46 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116132512.zyzt4gflticb6xz2@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®