From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751389AbdAQQrH (ORCPT ); Tue, 17 Jan 2017 11:47:07 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:38960 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750939AbdAQQrE (ORCPT ); Tue, 17 Jan 2017 11:47:04 -0500 Date: Tue, 17 Jan 2017 11:46:30 -0500 (EST) Message-Id: <20170117.114630.2113037516796589654.davem@davemloft.net> To: tremyfr@gmail.com Cc: mlindner@marvell.com, stephen@networkplumber.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: marvell: skge: use new api ethtool_{get|set}_link_ksettings From: David Miller In-Reply-To: <1484603168-18120-1-git-send-email-tremyfr@gmail.com> References: <1484603168-18120-1-git-send-email-tremyfr@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 17 Jan 2017 07:47:24 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Philippe Reynes Date: Mon, 16 Jan 2017 22:46:08 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > The callback set_link_ksettings no longer update the value > of advertising, as the struct ethtool_link_ksettings is > defined as const. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > > Signed-off-by: Philippe Reynes > --- > Changelog: > v2: > - update the commit log with a note to explain that this code > was not tested on hardware (feedback from Stephen Hemminger) Applied.