From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751109AbdAQIDz (ORCPT ); Tue, 17 Jan 2017 03:03:55 -0500 Received: from mx2.suse.de ([195.135.220.15]:51252 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751078AbdAQIDw (ORCPT ); Tue, 17 Jan 2017 03:03:52 -0500 Date: Tue, 17 Jan 2017 08:49:39 +0100 From: Michal Hocko To: "Huang, Ying" Cc: Tim Chen , Andrew Morton , dave.hansen@intel.com, ak@linux.intel.com, aaron.lu@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins , Shaohua Li , Minchan Kim , Rik van Riel , Andrea Arcangeli , "Kirill A . Shutemov" , Vladimir Davydov , Johannes Weiner , Hillf Danton , Christian Borntraeger , Jonathan Corbet Subject: Re: [PATCH v5 0/9] mm/swap: Regular page swap optimizations Message-ID: <20170117074939.GA19699@dhcp22.suse.cz> References: <20170116120236.GG13641@dhcp22.suse.cz> <878tqapkar.fsf@yhuang-dev.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878tqapkar.fsf@yhuang-dev.intel.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 17-01-17 09:06:04, Huang, Ying wrote: > Michal Hocko writes: > > > Hi, > > I am seeing a lot of preempt unsafe warnings with the current mmotm and > > I assume that this patchset has introduced the issue. I haven't checked > > more closely but get_swap_page didn't use this_cpu_ptr before "mm/swap: > > add cache for swap slots allocation" > > > > [ 57.812314] BUG: using smp_processor_id() in preemptible [00000000] code: kswapd0/527 > > [ 57.814360] caller is debug_smp_processor_id+0x17/0x19 > > [ 57.815237] CPU: 1 PID: 527 Comm: kswapd0 Tainted: G W 4.9.0-mmotm-00135-g4e9a9895ebef #1042 > > [ 57.816019] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.1-1 04/01/2014 > > [ 57.816019] ffffc900001939c0 ffffffff81329c60 0000000000000001 ffffffff81a0ce06 > > [ 57.816019] ffffc900001939f0 ffffffff81343c2a 00000000000137a0 ffffea0000dfd2a0 > > [ 57.816019] ffff88003c49a700 ffffc90000193b10 ffffc90000193a00 ffffffff81343c53 > > [ 57.816019] Call Trace: > > [ 57.816019] [] dump_stack+0x68/0x92 > > [ 57.816019] [] check_preemption_disabled+0xce/0xe0 > > [ 57.816019] [] debug_smp_processor_id+0x17/0x19 > > [ 57.816019] [] get_swap_page+0x19/0x183 > > [ 57.816019] [] shmem_writepage+0xce/0x38c > > [ 57.816019] [] shrink_page_list+0x81f/0xdbf > > [ 57.816019] [] shrink_inactive_list+0x2ab/0x594 > > [ 57.816019] [] shrink_node_memcg+0x4c7/0x673 > > [ 57.816019] [] shrink_node+0xc4/0x282 > > [ 57.816019] [] ? shrink_node+0xc4/0x282 > > [ 57.816019] [] kswapd+0x656/0x834 > > [ 57.816019] [] ? mem_cgroup_shrink_node+0x2e1/0x2e1 > > [ 57.816019] [] ? call_usermodehelper_exec_async+0x124/0x12d > > [ 57.816019] [] kthread+0xf9/0x101 > > [ 57.816019] [] ? _raw_spin_unlock_irq+0x2c/0x4a > > [ 57.816019] [] ? kthread_park+0x5a/0x5a > > [ 57.816019] [] ? umh_complete+0x25/0x25 > > [ 57.816019] [] ret_from_fork+0x27/0x40 > > Sorry for bothering, we should have tested this before. I am always running my tests with CONFIG_DEBUG_PREEMPT=y which is what has caught this one. [...] > > would be a way to go but the function takes a sleeping lock so disabling > > the preemption is not a way forward. So this is either preempt safe > > for some reason - which should be IMHO documented in a comment - and > > raw_cpu_ptr can be used or this needs a deeper thought. > > Thanks for pointing out this. > > We think this is preempt safe. During the development, we have > considered the possible preemption between getting the per-CPU pointer > and its usage, and implemented the code to make it work at that > situation. We will change the code to use raw_cpu_ptr() and add a > comment for it. FWIW s@this_cpu_ptr@raw_cpu_ptr@ which I am using as a workaround now hasn't seemed to cause any issue. At least nothing observable like a crash. Thanks! -- Michal Hocko SUSE Labs