From: Christoph Hellwig <hch@infradead.org>
To: David Miller <davem@davemloft.net>
Cc: dave.kleikamp@oracle.com, viro@zeniv.linux.org.uk,
sparclinux@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] coredump: Ensure proper size of sparse core files
Date: Mon, 16 Jan 2017 23:55:21 -0800 [thread overview]
Message-ID: <20170117075521.GA19654@infradead.org> (raw)
In-Reply-To: <20170116.224243.706466650029722351.davem@davemloft.net>
On Mon, Jan 16, 2017 at 10:42:43PM -0500, David Miller wrote:
> The lseek() done by dump_skip() should extend the file properly.
lseek never extends a file. It just moves the current file position.
So if you do not have a write after the lseek it does nothing.
next prev parent reply other threads:[~2017-01-17 7:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 18:11 [PATCH] " Dave Kleikamp
2017-01-11 19:25 ` [PATCH RESEND] " Dave Kleikamp
2017-01-17 3:42 ` David Miller
2017-01-17 7:55 ` Christoph Hellwig [this message]
2017-01-17 20:44 ` David Miller
2017-01-17 21:01 ` Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117075521.GA19654@infradead.org \
--to=hch@infradead.org \
--cc=dave.kleikamp@oracle.com \
--cc=davem@davemloft.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®