From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751055AbdAQIHP (ORCPT ); Tue, 17 Jan 2017 03:07:15 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:43442 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750968AbdAQIHM (ORCPT ); Tue, 17 Jan 2017 03:07:12 -0500 Date: Tue, 17 Jan 2017 09:06:11 +0100 From: Maxime Ripard To: Icenowy Zheng Cc: Rob Herring , Chen-Yu Tsai , Kishon Vijay Abraham I , Greg Kroah-Hartman , Bin Liu , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 1/4] phy: sun4i-usb: support PHY0 on H3 in MUSB mode Message-ID: <20170117080611.tn7s7ddj2csqr27m@lukather> References: <20170116191449.50397-1-icenowy@aosc.xyz> <20170116191449.50397-2-icenowy@aosc.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="h3tu3smfodeypoun" Content-Disposition: inline In-Reply-To: <20170116191449.50397-2-icenowy@aosc.xyz> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --h3tu3smfodeypoun Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 17, 2017 at 03:14:46AM +0800, Icenowy Zheng wrote: > The PHY0 on H3 can be wired either to MUSB controller or OHCI/EHCI > controller. >=20 > The original driver wired it to OHCI/EHCI controller; however, as the > code to use PHY0 as OHCI/EHCI is missing, it makes the PHY fully > unusable. >=20 > Rename the register (according to its function and the name in BSP > driver), and remove the code which wires the PHY0 to OHCI/EHCI, as MUSB > can support both peripheral and host mode (although the host mode of > MUSB is buggy). Can you elaborate on that? What's wrong with it? Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --h3tu3smfodeypoun Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYfdBuAAoJEBx+YmzsjxAg8ncP/0rbUeK7KAaZvd1b7esKmr3Q vE/06y3fUsJAkL1UiR8Id5vbxMUN1OIHyBordXNHPtJ7UQMAaoeaC2IK2vgRQj4A ATg4Efl0uVPoOsdxoqORv4l4e4Y8U8nj5lvMnMZQnVWcuxUDK++Q7eH7Di0GMDpJ b/NZTDSp6I8XpyFuYkzcKG5uEqS3wPAKYwSD4M2hMudhK3sx34sz2j4ZWkbyW8vX 0FT8Xd8guzMv/BE0DDQaHlWX+YUMmgANzCBAZd+Yhqj+nxJAsfkM2XNS3pDp+Qjo fbTqaeVvFK+gQ80rwF9A9+ghWY4qBGfuIqCdJRtZ5lMzMuEyllGj/9nrxeoHUmye BeAeAhLPlylVn2al8zfJjj78NyiQuM/AWwTb2AWXMjn6zAUd9xTRVpZM9G6xAHpw qX2RcJ0nBi3HIkMe24dzsRCqY7fIbnq8RZ8Z7qu/9YrJUMVH563J383t/EC/EwKV qRTDJ7XMwm1ZQ/w4kZ/UyiRzS0YG+pPWNFeP2zKCQuY/5rn+08XJ19DM9uf6zHW+ hcMJiMx5dJNvmIdR0+knzOZvZclJspawEnagVOfl7qCBS4+o2A3V9ys+vO722Wnj uKfJOo/E675REEEspmv2CLcxJTFJGiyESZcSqShmtlzbDDr/nwXCn2rprPCswveD YD5cM0FB3oEoiDwZTkX8 =q1qF -----END PGP SIGNATURE----- --h3tu3smfodeypoun--