From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751367AbdAQOu6 (ORCPT ); Tue, 17 Jan 2017 09:50:58 -0500 Received: from mail.kernel.org ([198.145.29.136]:55216 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750996AbdAQOuY (ORCPT ); Tue, 17 Jan 2017 09:50:24 -0500 Date: Tue, 17 Jan 2017 08:49:39 -0600 From: Bjorn Helgaas To: Marc Zyngier Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Bjorn Helgaas , Thomas Gleixner , stable@vger.kernel.org, Sebastian Andrzej Siewior , Duc Dang Subject: Re: [PATCH v2] PCI/MSI: pci-xgene-msi: Fix CPU hotplug registration handling Message-ID: <20170117144939.GC22776@bhelgaas-glaptop.roam.corp.google.com> References: <1484662916-9549-1-git-send-email-marc.zyngier@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484662916-9549-1-git-send-email-marc.zyngier@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 17, 2017 at 02:21:56PM +0000, Marc Zyngier wrote: > The conversion to the new hotplug state machine introduced a regression > where a successful hotplug registration would be treated as an error, > effectively disabling the MSI driver forever. > > Fix it by doing the proper check on the return value. > > Cc: Bjorn Helgaas > Cc: Thomas Gleixner > Cc: stable@vger.kernel.org > Fixes: 9c248f8896e6 ("PCI/xgene-msi: Convert to hotplug state machine") > Acked-by: Sebastian Andrzej Siewior > Tested-by: Duc Dang > Signed-off-by: Marc Zyngier Applied to for-linus for v4.10, thanks! > --- > * From v1: added Sebastian's Ack and Duc's Tested-by, cc'ing linux-pci > > drivers/pci/host/pci-xgene-msi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/host/pci-xgene-msi.c b/drivers/pci/host/pci-xgene-msi.c > index 1f38d08..f1b633b 100644 > --- a/drivers/pci/host/pci-xgene-msi.c > +++ b/drivers/pci/host/pci-xgene-msi.c > @@ -517,7 +517,7 @@ static int xgene_msi_probe(struct platform_device *pdev) > > rc = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "pci/xgene:online", > xgene_msi_hwirq_alloc, NULL); > - if (rc) > + if (rc < 0) > goto err_cpuhp; > pci_xgene_online = rc; > rc = cpuhp_setup_state(CPUHP_PCI_XGENE_DEAD, "pci/xgene:dead", NULL, > -- > 2.1.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html