From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752857AbdARVsX (ORCPT ); Wed, 18 Jan 2017 16:48:23 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:41682 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751085AbdARVsW (ORCPT ); Wed, 18 Jan 2017 16:48:22 -0500 Date: Wed, 18 Jan 2017 16:37:14 -0500 (EST) Message-Id: <20170118.163714.6755964924380784.davem@davemloft.net> To: linux@armlinux.org.uk Cc: andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC] net: dsa: remove unnecessary phy.h include From: David Miller In-Reply-To: <20170118001403.GJ27312@n2100.armlinux.org.uk> References: <20170118001403.GJ27312@n2100.armlinux.org.uk> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 18 Jan 2017 12:38:09 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Russell King - ARM Linux Date: Wed, 18 Jan 2017 00:14:03 +0000 > Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an > unnecessary dependency for quite a large amount of the kernel. There's > very little which actually requires definitions from phy.h in net/dsa.h > - the include itself only wants the declaration of a couple of > structures and IFNAMSIZ. > > Add linux/if.h for IFNAMSIZ, declarations for the structures, phy.h to > mv88e6xxx.h as it needs it for phy_interface_t, and remove both phy.h > and phy_fixed.h from net/dsa.h. > > This patch reduces from around 800 files rebuilt to around 40 - even > with ccache, the time difference is noticable. > > Signed-off-by: Russell King Applied, thanks.