From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753712AbdARWAv (ORCPT ); Wed, 18 Jan 2017 17:00:51 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:41992 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753630AbdARWAr (ORCPT ); Wed, 18 Jan 2017 17:00:47 -0500 Date: Wed, 18 Jan 2017 16:50:11 -0500 (EST) Message-Id: <20170118.165011.1105041451937157028.davem@davemloft.net> To: vivien.didelot@savoirfairelinux.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, f.fainelli@gmail.com, andrew@lunn.ch Subject: Re: [PATCH net-next 2/2] net: dsa: use cpu_switch instead of ds[0] From: David Miller In-Reply-To: <20170118014139.31417-2-vivien.didelot@savoirfairelinux.com> References: <20170118014139.31417-1-vivien.didelot@savoirfairelinux.com> <20170118014139.31417-2-vivien.didelot@savoirfairelinux.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 18 Jan 2017 12:51:06 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vivien Didelot Date: Tue, 17 Jan 2017 20:41:39 -0500 > Now that the DSA Ethernet switches are true Linux devices, the CPU > switch is not necessarily the first one. If its address is higher than > the second switch on the same MDIO bus, its index will be 1, not 0. > > Avoid any confusion by using dst->cpu_switch instead of dst->ds[0]. > > Signed-off-by: Vivien Didelot Applied.