From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752386AbdARJ7Z convert rfc822-to-8bit (ORCPT ); Wed, 18 Jan 2017 04:59:25 -0500 Received: from tyo185.gate.nec.co.jp ([114.179.232.185]:40884 "EHLO tyo185.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752310AbdARJ6Q (ORCPT ); Wed, 18 Jan 2017 04:58:16 -0500 X-Greylist: delayed 707 seconds by postgrey-1.27 at vger.kernel.org; Wed, 18 Jan 2017 04:58:15 EST From: Naoya Horiguchi To: Yisheng Xie CC: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "mhocko@suse.com" , "akpm@linux-foundation.org" , "minchan@kernel.org" , "vbabka@suse.cz" , "guohanjun@huawei.com" , "qiuxishi@huawei.com" Subject: Re: [RFC] HWPOISON: soft offlining for non-lru movable page Thread-Topic: [RFC] HWPOISON: soft offlining for non-lru movable page Thread-Index: AQHScUB1e3NW9Hi+iEWI60c6A+xcnKE9ZdaA Date: Wed, 18 Jan 2017 09:45:31 +0000 Message-ID: <20170118094530.GA29579@hori1.linux.bs1.fc.nec.co.jp> References: <1484712054-7997-1-git-send-email-xieyisheng1@huawei.com> In-Reply-To: <1484712054-7997-1-git-send-email-xieyisheng1@huawei.com> Accept-Language: en-US, ja-JP Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.128.101.30] Content-Type: text/plain; charset="iso-2022-jp" Content-ID: <44BE79BA9E6D6841B82AFFE2B547127A@gisp.nec.co.jp> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 18, 2017 at 12:00:54PM +0800, Yisheng Xie wrote: > This patch is to extends soft offlining framework to support > non-lru page, which already support migration after > commit bda807d44454 ("mm: migrate: support non-lru movable page > migration") > > When memory corrected errors occur on a non-lru movable page, > we can choose to stop using it by migrating data onto another > page and disable the original (maybe half-broken) one. > > Signed-off-by: Yisheng Xie It looks OK in my quick glance. I'll do some testing more tomorrow. Thanks, Naoya Horiguchi > --- > mm/memory-failure.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 53 insertions(+), 2 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index f283c7e..10043a4 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -1527,7 +1527,8 @@ static int get_any_page(struct page *page, unsigned long pfn, int flags) > { > int ret = __get_any_page(page, pfn, flags); > > - if (ret == 1 && !PageHuge(page) && !PageLRU(page)) { > + if (ret == 1 && !PageHuge(page) && > + !PageLRU(page) && !__PageMovable(page)) { > /* > * Try to free it. > */ > @@ -1549,6 +1550,54 @@ static int get_any_page(struct page *page, unsigned long pfn, int flags) > return ret; > } > > +static int soft_offline_movable_page(struct page *page, int flags) > +{ > + int ret; > + unsigned long pfn = page_to_pfn(page); > + LIST_HEAD(pagelist); > + > + /* > + * This double-check of PageHWPoison is to avoid the race with > + * memory_failure(). See also comment in __soft_offline_page(). > + */ > + lock_page(page); > + if (PageHWPoison(page)) { > + unlock_page(page); > + put_hwpoison_page(page); > + pr_info("soft offline: %#lx movable page already poisoned\n", > + pfn); > + return -EBUSY; > + } > + unlock_page(page); > + > + ret = isolate_movable_page(page, ISOLATE_UNEVICTABLE); > + /* > + * get_any_page() and isolate_movable_page() takes a refcount each, > + * so need to drop one here. > + */ > + put_hwpoison_page(page); > + if (!ret) { > + pr_info("soft offline: %#lx movable page failed to isolate\n", > + pfn); > + return -EBUSY; > + } > + > + list_add(&page->lru, &pagelist); > + ret = migrate_pages(&pagelist, new_page, NULL, MPOL_MF_MOVE_ALL, > + MIGRATE_SYNC, MR_MEMORY_FAILURE); > + if (ret) { > + if (!list_empty(&pagelist)) > + putback_movable_pages(&pagelist); > + > + pr_info("soft offline: %#lx: migration failed %d, type %lx\n", > + pfn, ret, page->flags); > + if (ret > 0) > + ret = -EIO; > + } > + > + return ret; > +} > + > static int soft_offline_huge_page(struct page *page, int flags) > { > int ret; > @@ -1705,8 +1754,10 @@ static int soft_offline_in_use_page(struct page *page, int flags) > > if (PageHuge(page)) > ret = soft_offline_huge_page(page, flags); > - else > + else if (PageLRU(page)) > ret = __soft_offline_page(page, flags); > + else > + ret = soft_offline_movable_page(page, flags); > > return ret; > } > -- > 1.7.12.4 >