From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752277AbdARKEQ (ORCPT ); Wed, 18 Jan 2017 05:04:16 -0500 Received: from mx2.suse.de ([195.135.220.15]:40404 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751898AbdARKDw (ORCPT ); Wed, 18 Jan 2017 05:03:52 -0500 Date: Wed, 18 Jan 2017 10:51:48 +0100 From: Michal Hocko To: Yisheng Xie Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, n-horiguchi@ah.jp.nec.com, akpm@linux-foundation.org, minchan@kernel.org, vbabka@suse.cz, guohanjun@huawei.com, qiuxishi@huawei.com Subject: Re: [RFC] HWPOISON: soft offlining for non-lru movable page Message-ID: <20170118095148.GK7015@dhcp22.suse.cz> References: <1484712054-7997-1-git-send-email-xieyisheng1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484712054-7997-1-git-send-email-xieyisheng1@huawei.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 18-01-17 12:00:54, Yisheng Xie wrote: > This patch is to extends soft offlining framework to support > non-lru page, which already support migration after > commit bda807d44454 ("mm: migrate: support non-lru movable page > migration") > > When memory corrected errors occur on a non-lru movable page, > we can choose to stop using it by migrating data onto another > page and disable the original (maybe half-broken) one. soft_offline_movable_page duplicates quite a lot from __soft_offline_page. Would it be better to handle both cases in __soft_offline_page? -- Michal Hocko SUSE Labs