From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752798AbdARNdV (ORCPT ); Wed, 18 Jan 2017 08:33:21 -0500 Received: from lug-owl.de ([195.71.106.12]:52297 "EHLO lug-owl.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751769AbdARNdP (ORCPT ); Wed, 18 Jan 2017 08:33:15 -0500 X-Greylist: delayed 653 seconds by postgrey-1.27 at vger.kernel.org; Wed, 18 Jan 2017 08:32:12 EST Date: Wed, 18 Jan 2017 14:14:29 +0100 From: Jan-Benedict Glaw To: SF Markus Elfring Cc: linux-alpha@vger.kernel.org, Al Viro , Ivan Kokshaysky , Matt Turner , Nicolas Pitre , Richard Cochran , Richard Henderson , Thomas Gleixner , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 4/4] alpha: Move two assignments for the variable "res" in srm_env_proc_write() Message-ID: <20170118131429.GA12614@lug-owl.de> Mail-Followup-To: SF Markus Elfring , linux-alpha@vger.kernel.org, Al Viro , Ivan Kokshaysky , Matt Turner , Nicolas Pitre , Richard Cochran , Richard Henderson , Thomas Gleixner , LKML , kernel-janitors@vger.kernel.org References: <986573fa-e636-f864-14dc-5e65a31b454e@users.sourceforge.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fdj2RfSjLxBAspz7" Content-Disposition: inline In-Reply-To: <986573fa-e636-f864-14dc-5e65a31b454e@users.sourceforge.net> X-Operating-System: Linux mail 3.2.0-4-686-pae X-gpg-fingerprint: 250D 3BCF 7127 0D8C A444 A961 1DBD 5E75 8399 E1BB X-gpg-key: wwwkeys.de.pgp.net X-Echelon-Enable: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll X-TKUeV: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll X-message-flag: Please send plain text messages only. Do not send HTML emails. Thank you. User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --fdj2RfSjLxBAspz7 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, 2017-01-18 12:50:17 +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 18 Jan 2017 12:08:44 +0100 >=20 > A local variable was set to an error code in two cases before a concrete > error situation was detected. Thus move the corresponding assignment into > an if branch to indicate a software failure there. >=20 > This issue was detected by using the Coccinelle software. >=20 > Signed-off-by: Markus Elfring Acked-by: Jan-Benedict Glaw MfG, JBG --=20 Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481 Signature of: http://www.chiark.greenend.org.uk/~sgtatham/bugs.h= tml the second : --fdj2RfSjLxBAspz7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlh/ajUACgkQHb1edYOZ4btr9ACeOYcsgk9UkisSQZbnI6/Qxn8O J5MAnjEHIg5BWUJV7jgL/Hp5uUqNuFI4 =GqLd -----END PGP SIGNATURE----- --fdj2RfSjLxBAspz7--