From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753764AbdAROLJ (ORCPT ); Wed, 18 Jan 2017 09:11:09 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:41304 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751396AbdAROLI (ORCPT ); Wed, 18 Jan 2017 09:11:08 -0500 Date: Wed, 18 Jan 2017 14:11:03 +0000 From: Al Viro To: SF Markus Elfring Cc: linux-alpha@vger.kernel.org, Ivan Kokshaysky , Jan-Benedict Glaw , Matt Turner , Nicolas Pitre , Richard Cochran , Richard Henderson , Thomas Gleixner , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 4/4] alpha: Move two assignments for the variable "res" in srm_env_proc_write() Message-ID: <20170118141103.GD1555@ZenIV.linux.org.uk> References: <986573fa-e636-f864-14dc-5e65a31b454e@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <986573fa-e636-f864-14dc-5e65a31b454e@users.sourceforge.net> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 18, 2017 at 12:50:17PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 18 Jan 2017 12:08:44 +0100 > > A local variable was set to an error code in two cases before a concrete > error situation was detected. Thus move the corresponding assignment into > an if branch to indicate a software failure there. > > This issue was detected by using the Coccinelle software. Why the hell is that an issue? It's a common enough idiom, and while these functions are far from being hot paths, blind patches like that are very much to be discouraged. NAK.