From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753748AbdASQba (ORCPT ); Thu, 19 Jan 2017 11:31:30 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:59330 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753514AbdASQas (ORCPT ); Thu, 19 Jan 2017 11:30:48 -0500 Date: Thu, 19 Jan 2017 11:23:07 -0500 (EST) Message-Id: <20170119.112307.1679144601793219397.davem@davemloft.net> To: arnd@arndb.de Cc: jhs@mojatatu.com, jiri@mellanox.com, hadarh@mellanox.com, amir@vadai.me, paulb@mellanox.com, ogerlitz@mellanox.com, simon.horman@netronome.com, roid@mellanox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net/sched: cls_flower: reduce fl_change stack size From: David Miller In-Reply-To: <20170119094551.2780983-1-arnd@arndb.de> References: <20170119094551.2780983-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 19 Jan 2017 07:24:03 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Thu, 19 Jan 2017 10:45:31 +0100 > The new ARP support has pushed the stack size over the edge on ARM, > as there are two large objects on the stack in this function (mask > and tb) and both have now grown a bit more: > > net/sched/cls_flower.c: In function 'fl_change': > net/sched/cls_flower.c:928:1: error: the frame size of 1072 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] > > We can solve this by dynamically allocating one or both of them. > I first tried to do it just for the mask, but that only saved > 152 bytes on ARM, while this version just does it for the 'tb' > array, bringing the stack size back down to 664 bytes. > > Fixes: 99d31326cbe6 ("net/sched: cls_flower: Support matching on ARP") > Signed-off-by: Arnd Bergmann Applied.