From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751256AbdASIzV (ORCPT ); Thu, 19 Jan 2017 03:55:21 -0500 Received: from mx2.suse.de ([195.135.220.15]:52601 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750717AbdASIzT (ORCPT ); Thu, 19 Jan 2017 03:55:19 -0500 Date: Thu, 19 Jan 2017 09:55:16 +0100 From: Johannes Thumshirn To: John Garry Cc: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, linuxarm@huawei.com, zhangfei.gao@linaro.org, xuwei5@hisilicon.com, john.garry2@mail.dcu.ie, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Xiang Chen Subject: Re: [PATCH 6/7] scsi: hisi_sas: fix probe ordering problem Message-ID: <20170119085516.GJ5054@linux-x5ow.site> References: <1484757173-235951-1-git-send-email-john.garry@huawei.com> <1484757173-235951-7-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1484757173-235951-7-git-send-email-john.garry@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 19, 2017 at 12:32:52AM +0800, John Garry wrote: > From: Xiang Chen > > There is a potential probe issue in how we trigger the hw initialisation. > Although we use 1s timer to delay hw initialisation, there is still a > potential that sas_register_ha() is not be finished before we start > the PHY init from hw->hw_init(). > To avoid this issue, initialise the hw after sas_register_ha() in the > same probe context. > Note: it is not necessary to use 1s timer now (modified v2 hw only). > > Signed-off-by: Xiang Chen > Signed-off-by: John Garry > --- Looks OK, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850