From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753654AbdASQb2 (ORCPT ); Thu, 19 Jan 2017 11:31:28 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:34278 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753456AbdASQbS (ORCPT ); Thu, 19 Jan 2017 11:31:18 -0500 Date: Thu, 19 Jan 2017 16:24:38 +0000 From: Russell King - ARM Linux To: Andy Gross Cc: lorenzo.pieralisi@arm.com, linux-arm-msm@vger.kernel.org, will.deacon@arm.com, linux-kernel@vger.kernel.org, Bjorn Andersson , Srinivas Kandagatla , Kevin Hilman , linux-arm-kernel@lists.infradead.org Subject: Re: [Patch v3 1/2] arm: kernel: Add SMC structure parameter Message-ID: <20170119162438.GF27312@n2100.armlinux.org.uk> References: <1484173918-25090-1-git-send-email-andy.gross@linaro.org> <1484173918-25090-2-git-send-email-andy.gross@linaro.org> <20170119144008.GA27312@n2100.armlinux.org.uk> <20170119154506.GB9631@hector.attlocal.net> <20170119154818.GE27312@n2100.armlinux.org.uk> <20170119161658.GC9631@hector.attlocal.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170119161658.GC9631@hector.attlocal.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 19, 2017 at 10:16:58AM -0600, Andy Gross wrote: > On Thu, Jan 19, 2017 at 03:48:18PM +0000, Russell King - ARM Linux wrote: > > Please add that detail to the kerneldoc comments for the structure > > concerning state.a6. It's important that such information is not > > lost in the depths of history. > > For documentation, should I split out the union separately? I don't see any > good examples for documenting union members in unions defined inside structures. Good question - I don't know. @state.a6: blah would seem to be a logical and unambiguous way to document it, but I don't know whether kerneldoc will accept that. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.