From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: linux-input@vger.kernel.org
Cc: Thierry Reding <thierry.reding@gmail.com>,
linux-kernel@vger.kernel.org,
David Lechner <david@lechnology.com>,
Frieder Schrempf <frieder.schrempf@exceet.de>
Subject: [PATCH v2 3/7] Input: pwm-beeper - use input_set_capability()
Date: Thu, 19 Jan 2017 14:40:53 -0800 [thread overview]
Message-ID: <20170119224057.9995-3-dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20170119224057.9995-1-dmitry.torokhov@gmail.com>
Instead of manipulating capability bits directly, let's use
input_set_capability() API.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/misc/pwm-beeper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c
index 14c52054f5b7..ce6eec48ec5f 100644
--- a/drivers/input/misc/pwm-beeper.c
+++ b/drivers/input/misc/pwm-beeper.c
@@ -131,8 +131,8 @@ static int pwm_beeper_probe(struct platform_device *pdev)
beeper->input->id.product = 0x0001;
beeper->input->id.version = 0x0100;
- beeper->input->evbit[0] = BIT(EV_SND);
- beeper->input->sndbit[0] = BIT(SND_TONE) | BIT(SND_BELL);
+ input_set_capability(beeper->input, EV_SND, SND_TONE);
+ input_set_capability(beeper->input, EV_SND, SND_BELL);
beeper->input->event = pwm_beeper_event;
beeper->input->close = pwm_beeper_close;
--
2.11.0.483.g087da7b7c-goog
next prev parent reply other threads:[~2017-01-19 22:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 22:40 [PATCH v2 1/7] Input: pwm-beeper - remove calls to legacy pwm_request API Dmitry Torokhov
2017-01-19 22:40 ` [PATCH v2 2/7] Input: pwm-beeper - switch to using managed resources Dmitry Torokhov
2017-01-20 10:10 ` Thierry Reding
2017-01-19 22:40 ` Dmitry Torokhov [this message]
2017-01-20 10:12 ` [PATCH v2 3/7] Input: pwm-beeper - use input_set_capability() Thierry Reding
2017-01-19 22:40 ` [PATCH v2 4/7] Input: pwm-beeper - fix race when suspending Dmitry Torokhov
2017-01-20 10:14 ` Thierry Reding
2017-01-19 22:40 ` [PATCH v2 5/7] Input: pwm-beeper - suppress error message on probe defer Dmitry Torokhov
2017-01-20 10:16 ` Thierry Reding
2017-01-20 18:43 ` David Lechner
2017-01-19 22:40 ` [PATCH v2 6/7] Input: pwm-beeper - add optional amplifier regulator Dmitry Torokhov
2017-01-20 10:19 ` Thierry Reding
2017-01-20 17:47 ` Dmitry Torokhov
2017-01-19 22:40 ` [PATCH v2 7/7] Input: pwm-beeper - switch to using "atomic" PWM API Dmitry Torokhov
2017-01-20 10:23 ` Thierry Reding
2017-01-20 10:08 ` [PATCH v2 1/7] Input: pwm-beeper - remove calls to legacy pwm_request API Thierry Reding
2017-01-20 19:37 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119224057.9995-3-dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=david@lechnology.com \
--cc=frieder.schrempf@exceet.de \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome