From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752895AbdATQZv (ORCPT ); Fri, 20 Jan 2017 11:25:51 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:60924 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752585AbdATQZs (ORCPT ); Fri, 20 Jan 2017 11:25:48 -0500 Date: Fri, 20 Jan 2017 11:15:54 -0500 (EST) Message-Id: <20170120.111554.775311724296711536.davem@davemloft.net> To: arnd@arndb.de Cc: hariprasad@chelsio.com, ganeshgr@chelsio.com, rahul.lakkireddy@chelsio.com, varun@chelsio.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] cxgb4: hide unused warnings From: David Miller In-Reply-To: <20170118145306.1004008-1-arnd@arndb.de> References: <20170118145306.1004008-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 20 Jan 2017 07:16:50 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Wed, 18 Jan 2017 15:52:51 +0100 > The two new variables are only used inside of an #ifdef and cause > harmless warnings when that is disabled: > > drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c: In function 'init_one': > drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:4646:9: error: unused variable 'port_vec' [-Werror=unused-variable] > drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:4646:6: error: unused variable 'v' [-Werror=unused-variable] > > This adds another #ifdef around the declarations. > > Fixes: 96fe11f27b70 ("cxgb4: Implement ndo_get_phys_port_id for mgmt dev") > Signed-off-by: Arnd Bergmann Applied.