From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753058AbdATQ0f (ORCPT ); Fri, 20 Jan 2017 11:26:35 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:60960 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752996AbdATQ0d (ORCPT ); Fri, 20 Jan 2017 11:26:33 -0500 Date: Fri, 20 Jan 2017 11:26:26 -0500 (EST) Message-Id: <20170120.112626.159194842548687734.davem@davemloft.net> To: colin.king@canonical.com Cc: vyasevich@gmail.com, nhorman@tuxdriver.com, linux-sctp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: sctp: fix array overrun read on sctp_timer_tbl From: David Miller In-Reply-To: <20170120130157.20034-1-colin.king@canonical.com> References: <20170120130157.20034-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 20 Jan 2017 07:27:22 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Fri, 20 Jan 2017 13:01:57 +0000 > From: Colin Ian King > > The comparison on the timeout can lead to an array overrun > read on sctp_timer_tbl because of an off-by-one error. Fix > this by using < instead of <= and also compare to the array > size rather than SCTP_EVENT_TIMEOUT_MAX. > > Fixes CoverityScan CID#1397639 ("Out-of-bounds read") > > Signed-off-by: Colin Ian King Applied.