From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752920AbdATQgJ (ORCPT ); Fri, 20 Jan 2017 11:36:09 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:32836 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752982AbdATQgG (ORCPT ); Fri, 20 Jan 2017 11:36:06 -0500 Date: Fri, 20 Jan 2017 11:34:47 -0500 (EST) Message-Id: <20170120.113447.2060254584042448007.davem@davemloft.net> To: Joao.Pinto@synopsys.com Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com, netdev@vger.kernel, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] net: stmicro: eQOS IP Core From: David Miller In-Reply-To: References: <4584830fd1416af69ddb2e0168f78b1e343c33fe.1484914583.git.jpinto@synopsys.com> <20170120.112025.283503761726233382.davem@davemloft.net> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 20 Jan 2017 07:35:43 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joao Pinto Date: Fri, 20 Jan 2017 16:30:41 +0000 > Charade of renames? It is a bit strong, don't you agree? Not at all. > So you suggest to keep the driver called as dwmac4 when the IP is in fact eQOS? > Where do you suggest to put the eQOS 5.x features? Since you are adding the new code, you can name the functions that implement eQOS 5.x support however you like. You don't have to rename the dwmac4 code in order to add support for new chip families.