From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752043AbdATMRT (ORCPT ); Fri, 20 Jan 2017 07:17:19 -0500 Received: from celine.tisys.org ([85.25.117.166]:46668 "EHLO celine.tisys.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751719AbdATMRR (ORCPT ); Fri, 20 Jan 2017 07:17:17 -0500 Date: Fri, 20 Jan 2017 13:07:05 +0100 From: Nils Holland To: Michel =?iso-8859-1?Q?D=E4nzer?= Cc: amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: amdgpu: Corrupted video on 32 bit systems (possible fix) Message-ID: <20170120120704.GA11366@teela.fritz.box> References: <20170119193537.GA3296@teela.fritz.box> <40da3f7e-6634-7588-36b5-f03378faee26@daenzer.net> <20170120074427.GA2793@boerne.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 20, 2017 at 06:11:50PM +0900, Michel Dänzer wrote: > On 20/01/17 04:44 PM, Nils Holland wrote: > > > > Sounds like a good idea! I was a bit heasitant because, to be honest, > > I'm not at all an expert about the code in question and basically only > > saw how you fixed the issue in radeon and thought: "Well, let's see if > > I can do the same thing in amdgpu and if so, if it helps there, too". > > ;-) > > > > However, since you've said that a 32 bit fix in amdgpu generally seems > > like a good idea, > > Actually, unless your CPU can't run 64-bit code, I'd say running a > 64-bit kernel would be an overall even better idea for you, even with > 32-bit userspace. :) Anyway, this problem clearly needs to be fixed. Yep, that's certainly true! However, I have to admit that I'm intentionally regularly testing all kinds of stuff on pure 32 bit, because I think that most of the other "first like of testing", i.e. the developers themselves, are primarily working with 64 bit these days. So I thought it might make sense if someone keeps a little of an eye on 32 bit - after all, in general and if there are no technical reasons that speak agsinst it, things should work there, too. And indeed, during the past year I've spotted a few little things that were only causing problems on 32 bit - both in the kernel and other components like systemd - and which could subsequently be fixed in a relatively easy manner. > > I would indeed use a little time on the weekend to get a proper patch > > ready and submit it for review. Even if the "no wc for x86_32" part is > > probably the only thing it'll contain > > I wouldn't bother with that. There is no real reason against bringing it > all over in one go. Right, I'll see what I can do over the weekend. So stay tuned for my first ever proper (at least as far as the guidelines for submitting patches are concerned) patch and expect the worst. ;-) Greetings Nils