From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753231AbdATTTx (ORCPT ); Fri, 20 Jan 2017 14:19:53 -0500 Received: from mail-pg0-f51.google.com ([74.125.83.51]:33938 "EHLO mail-pg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752966AbdATTTv (ORCPT ); Fri, 20 Jan 2017 14:19:51 -0500 Date: Fri, 20 Jan 2017 11:19:48 -0800 From: Brian Norris To: Jeffy Chen Cc: linux-bluetooth@vger.kernel.org, Amitkumar Karwar , Marcel Holtmann , Johan Hedberg , Gustavo Padovan , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] btmrvl: use dt's irqflags for wakeup pin Message-ID: <20170120191947.GA84521@google.com> References: <1484910860-7690-1-git-send-email-jeffy.chen@rock-chips.com> <1484910860-7690-3-git-send-email-jeffy.chen@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484910860-7690-3-git-send-email-jeffy.chen@rock-chips.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 20, 2017 at 07:14:20PM +0800, Jeffy Chen wrote: > Use irqflags parsed from dt. > > Signed-off-by: Jeffy Chen > --- > > drivers/bluetooth/btmrvl_sdio.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c > index 796f719..23711fe 100644 > --- a/drivers/bluetooth/btmrvl_sdio.c > +++ b/drivers/bluetooth/btmrvl_sdio.c > @@ -101,8 +101,7 @@ static int btmrvl_sdio_probe_of(struct device *dev, > } else { > ret = devm_request_irq(dev, cfg->irq_bt, > btmrvl_wake_irq_bt, > - IRQF_TRIGGER_LOW, IRQF_TRIGGER_LOW is often accurate, since Marvell devices seem to always physically use an active low signal here. But there could always be some kind of inverter logic on the board, for instance, so it makes sense to just let the device tree specify these flags for us. Also, I don't actually see any in-tree users of this yet (at least, I see no proper "marvell,sd*-bt" compatible properties), so I don't see anyone who might have specified this incorrectly yet... So: Reviewed-by: Brian Norris > - "bt_wake", cfg); > + 0, "bt_wake", cfg); > if (ret) { > dev_err(dev, > "Failed to request irq_bt %d (%d)\n", > -- > 2.1.4 > >