From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752485AbdATXUw (ORCPT ); Fri, 20 Jan 2017 18:20:52 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:45916 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751201AbdATXUu (ORCPT ); Fri, 20 Jan 2017 18:20:50 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 91E8760715 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Fri, 20 Jan 2017 15:20:49 -0800 From: Stephen Boyd To: Stanimir Varbanov Cc: Rajendra Nayak , mturquette@baylibre.com, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, sricharan@codeaurora.org Subject: Re: [PATCH] clk: qcom: gdsc: Fix handling of hw control enable/disable Message-ID: <20170120232049.GB20800@codeaurora.org> References: <1484027679-18397-1-git-send-email-rnayak@codeaurora.org> <3164de46-a251-3b3f-e6f5-5c3699bb4df8@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3164de46-a251-3b3f-e6f5-5c3699bb4df8@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/10, Stanimir Varbanov wrote: > > > + udelay(1); > > + > > + reg = sc->gds_hw_ctrl ? sc->gds_hw_ctrl : sc->gdscr; > > + ret = gdsc_poll_status(sc, reg, 0); > > This should be gdsc_poll_status(sc, reg, true) because after disabling > hw_control we expect that the GDSC is in power_on state. > > > + if (ret) > > + return ret; > > } > > > > if (sc->pwrsts & PWRSTS_OFF) > > I expect this patch is going for v2? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project